Always sort root pages by language first #2831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix in #2819 was not correct. Luckily, merging the changes in Contao 4.11 showed the problem.
Example case:
deindexpage indeenindexpage inenThe changes in #2819 would sort the english
indexpage before any root pages. This means even if a user requestsdeas preferred language, she would not land on the german home page. This means the changes in #2819 need to be reverted.While debugging the routing through
route:match(thanks @dmolineus) I noticed the fallback page is not preferred if no language is given. Applying the fallback sorting fixes the initial issue in #2819 as well, most likely because bubblesort now correctly compares the necessary pages.