-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dispatch an event to define metadata inside the FigureBuilder #3019
Dispatch an event to define metadata inside the FigureBuilder #3019
Conversation
Co-authored-by: Martin Auswöger <martin@auswoeger.com>
e1bef69
to
d24fdb7
Compare
I would prefer |
It is |
We could also put the event in the File namespace. But that's not consistent with the other ones. I have no strong preferences but would try to avoid having the FigureBuilder in the name. |
Then let's go with |
e1a8c0e
to
cee78dc
Compare
Thank you @m-vo. |
This introduces a
DefineMetadataEvent
that gets dispatched inside theFigureBuilder
as soon as metadata is requested. It is run after theFigureBuilder
logic and allows to remove/replace/addMetadata
.