Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing fallback for densities in preview factory #4094

Merged
merged 2 commits into from
Feb 9, 2022
Merged

Fix missing fallback for densities in preview factory #4094

merged 2 commits into from
Feb 9, 2022

Conversation

m-vo
Copy link
Member

@m-vo m-vo commented Feb 9, 2022 •
edited
Loading

If an image config specified items but omitted the densities key in these items, an invalid array access would occur when generating previews.

This PR fixes that by adding a fallback.

@m-vo m-vo added the bug label Feb 9, 2022
@m-vo m-vo added this to the 4.13 milestone Feb 9, 2022
@m-vo m-vo requested a review from ausi February 9, 2022 13:08
@m-vo m-vo self-assigned this Feb 9, 2022
@leofeyer leofeyer merged commit 99a73db into contao:4.13 Feb 9, 2022
@leofeyer
Copy link
Member

leofeyer commented Feb 9, 2022

Thank you @m-vo.

@m-vo m-vo deleted the bugfix/preview-factory-densities branch July 5, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ausi ausi ausi approved these changes

@Toflar Toflar Toflar approved these changes

Assignees

@m-vo m-vo

Labels
bug
Projects
None yet
Milestone
4.13
Development

Successfully merging this pull request may close these issues.
4 participants
@m-vo @leofeyer @ausi @Toflar