Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the Contao 3 class loader #4314

Merged
merged 2 commits into from Mar 21, 2022
Merged

Remove the Contao 3 class loader #4314

merged 2 commits into from Mar 21, 2022

Conversation

leofeyer
Copy link
Member

No description provided.

@leofeyer leofeyer added this to the 5.0 milestone Mar 21, 2022
@leofeyer leofeyer requested a review from a team March 21, 2022 12:48
@leofeyer leofeyer self-assigned this Mar 21, 2022
aschempp
aschempp previously approved these changes Mar 21, 2022
View reviewed changes
fritzmg
fritzmg previously approved these changes Mar 21, 2022
View reviewed changes
@leofeyer leofeyer dismissed stale reviews from fritzmg and aschempp via 81b5932 March 21, 2022 13:29
@leofeyer leofeyer merged commit 83f481f into contao:5.x Mar 21, 2022
@leofeyer leofeyer deleted the feature/class-loader branch March 21, 2022 13:36
@bytehead bytehead mentioned this pull request Mar 21, 2022
Merged
@aschempp aschempp added this to Done in Contao 5 Mar 21, 2022
bytehead added a commit to bytehead/contao that referenced this pull request Mar 21, 2022
@bytehead
Use FQCN because the class alias is gone since contao#4314
c70ff82
leofeyer pushed a commit that referenced this pull request Mar 21, 2022
@bytehead
Use FQCN instead of aliased class name (see #4322)
bbdc6b7 
Description
-----------

Follow up for #4314

```
Symfony\Component\ErrorHandler\Error\ClassNotFoundError:
Attempted to load class "DC_Table" from the global namespace.
Did you forget a "use" statement?

  at /contao/core-bundle/src/Resources/contao/classes/Backend.php:417
  at Contao\Backend->getBackendModule('page', null)
     (/contao/core-bundle/src/Resources/contao/controllers/BackendMain.php:154)
  at Contao\BackendMain->run()
     (/contao/core-bundle/src/Controller/BackendController.php:49)
  at Contao\CoreBundle\Controller\BackendController->mainAction()
     (vendor/symfony/http-kernel/HttpKernel.php:152)
  at Symfony\Component\HttpKernel\HttpKernel->handleRaw(object(Request), 1)
     (vendor/symfony/http-kernel/HttpKernel.php:74)
  at Symfony\Component\HttpKernel\HttpKernel->handle(object(Request), 1, true)
     (vendor/symfony/http-kernel/Kernel.php:202)
  at Symfony\Component\HttpKernel\Kernel->handle(object(Request))
     (public/index.php:43)
```

Commits
-------

c70ff82 Use FQCN because the class alias is gone since #4314
409e41e Fix CS
1b8226c Fix some tests
7970df6 Fix test
1654102 Fix phpstan
90f588b Still use the switch statement
1424d83 Use FQCN for StringUtil
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschempp aschempp aschempp left review comments

@fritzmg fritzmg fritzmg left review comments

Assignees

@leofeyer leofeyer

Labels
feature
Projects
Contao 5
Done
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leofeyer @aschempp @fritzmg