Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced the BE_CELL_SIZE cookie by a localstorage entry #468

Merged
merged 1 commit into from
May 2, 2019

Conversation

Toflar
Copy link
Member

@Toflar Toflar commented May 1, 2019

No description provided.

@leofeyer leofeyer added this to the 4.8.0 milestone May 2, 2019
@leofeyer leofeyer merged commit 483f40b into contao:master May 2, 2019
@leofeyer
Copy link
Member

leofeyer commented May 2, 2019

Thank you @Toflar.

@Toflar Toflar deleted the feature/remove-be-cell-size-cookie branch May 2, 2019 11:13
leofeyer added a commit that referenced this pull request May 2, 2019
@aschempp
Copy link
Member

aschempp commented May 6, 2019

We're not removing existing cookies, are we?

@Toflar
Copy link
Member Author

Toflar commented May 7, 2019

We don't need to. Nobody else is setting this cookie (in contrast to the BE_PAGE_OFFSET so there's no point in doing so.

@aschempp
Copy link
Member

aschempp commented May 7, 2019

I was talking about the cookie already being present. But then again that can only be backend users and the cookie will expire automatically. Should be fine imho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants