Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced the BE_CELL_SIZE cookie by a localstorage entry #468

Merged
merged 1 commit into from May 2, 2019

Conversation

@Toflar
Copy link
Member

commented May 1, 2019

No description provided.

@leofeyer leofeyer added the feature label May 2, 2019

@leofeyer leofeyer added this to the 4.8.0 milestone May 2, 2019

@leofeyer leofeyer merged commit 483f40b into contao:master May 2, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 88.724%
Details
@leofeyer

This comment has been minimized.

Copy link
Member

commented May 2, 2019

Thank you @Toflar.

@Toflar Toflar deleted the Toflar:feature/remove-be-cell-size-cookie branch May 2, 2019

leofeyer added a commit that referenced this pull request May 2, 2019
@aschempp

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

We're not removing existing cookies, are we?

@Toflar

This comment has been minimized.

Copy link
Member Author

commented May 7, 2019

We don't need to. Nobody else is setting this cookie (in contrast to the BE_PAGE_OFFSET so there's no point in doing so.

@aschempp

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

I was talking about the cookie already being present. But then again that can only be backend users and the cookie will expire automatically. Should be fine imho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.