-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable the request token check for idempotent actions #5461
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
This reenables the CSRF vulnerability that we had closed in contao/core#4007, doesn‘t it? @ausi /cc |
The original issue was about editing and deleting. The request token check is still in place for |
Anything we know is idempotent, does not need a token. |
Are we sure, that |
Yes, that's the whole purpose of this PR :D |
Technically, someone could manipulate data in the |
FINALLY removes the request token check for idempotent actions in the back end.