Use executeStatement() instead of query() in search #5470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofeyer
approved these changes
Nov 2, 2022
|
Thank you @ausi. |
aschempp
reviewed
Nov 4, 2022
| * | ||
| * @return int The number of affected rows | ||
| */ | ||
| public function executeStatement(string $strQuery): int |
There was a problem hiding this comment.
shouldn't we also allow for parameters and types like doctrine does?
There was a problem hiding this comment.
Don’t think so, this is merely a replacement for ->query() that works with non-SELECT statements.
If you need parameters and types you should use the database_connection services instead anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix the deprecations in #5468