Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use session to store the last visited page #565

Merged
merged 4 commits into from Jul 9, 2019

Conversation

Projects
None yet
3 participants
@aschempp
Copy link
Contributor

commented Jul 8, 2019

There is only one difference now that I can think of: If you open the login page, and then manually reload, the previous page will be gone…

@aschempp aschempp requested review from ausi, Toflar and leofeyer Jul 8, 2019

@leofeyer leofeyer added the defect label Jul 8, 2019

@leofeyer leofeyer added this to the 4.8 milestone Jul 8, 2019

@Toflar

Toflar approved these changes Jul 8, 2019

Copy link
Member

left a comment

Looks good to me :)

@leofeyer

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

If you open the login page, and then manually reload, the previous page will be gone

Will this also be the case if someone submits the form with invalid data?

@aschempp

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

If you open the login page, and then manually reload, the previous page will be gone

Will this also be the case if someone submits the form with invalid data?

No, why? Then the post value will be available, which points to the original referer.

@leofeyer

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

Then I don't consider this a problem.

@leofeyer leofeyer merged commit 51c434e into master Jul 9, 2019

5 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage increased (+0.4%) to 87.485%
Details
@leofeyer

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

Thank you @aschempp.

@leofeyer leofeyer deleted the bugfix/last-page-visited branch Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.