Rewrite tree mode toggling to Stimulus controller #6527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofeyer
pushed a commit
that referenced
this pull request
Nov 14, 2023
leofeyer
pushed a commit
to contao/core-bundle
that referenced
this pull request
Nov 14, 2023
Description ----------- extracted for contao/contao#6527 Commits ------- addc5183 Automatically generate the global operations
aschempp
force-pushed
the
feature/toggle-structure
branch
from
275af2c
to
23a28c3
Compare
leofeyer
approved these changes
Nov 22, 2023
|
Thank you @aschempp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces our legacy
toggleStructureandtoggleFileTreeto a universal Stimulus controller that implements the behaviour for both drivers.Additionally, it makes setting global operations optional because they can now be generated automatically. Might want to refactor this into a separate PR though.(see #6528)This changes the following behaviour:
level 1while DC_Table starts a tree atlevel 0. This has no been unified (always start at 0). It only affectsDC_Folder::ajaxTreeView()argument, so I doubt this will be an issue.ref(referrer ID) in the URL with the current value. Because our framework generated a new referer ID on every request. It now keeps the current referer ID for ajax requests (ifrefis given in the request).