Automatically generate the global operations #6528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofeyer
approved these changes
Nov 14, 2023
|
Thank you @aschempp. |
leofeyer
pushed a commit
that referenced
this pull request
Nov 14, 2023
leofeyer
pushed a commit
to contao/calendar-bundle
that referenced
this pull request
Nov 14, 2023
Description ----------- Forgot to adjust bundles in contao/contao#6528 Commits ------- eba6e349 Also remove global operations in bundles
leofeyer
pushed a commit
to contao/faq-bundle
that referenced
this pull request
Nov 14, 2023
Description ----------- Forgot to adjust bundles in contao/contao#6528 Commits ------- eba6e349 Also remove global operations in bundles
leofeyer
pushed a commit
to contao/newsletter-bundle
that referenced
this pull request
Nov 14, 2023
Description ----------- Forgot to adjust bundles in contao/contao#6528 Commits ------- eba6e349 Also remove global operations in bundles
leofeyer
pushed a commit
to contao/comments-bundle
that referenced
this pull request
Nov 14, 2023
Description ----------- Forgot to adjust bundles in contao/contao#6528 Commits ------- eba6e349 Also remove global operations in bundles
leofeyer
pushed a commit
to contao/core-bundle
that referenced
this pull request
Nov 14, 2023
Description ----------- Forgot to adjust bundles in contao/contao#6528 Commits ------- eba6e349 Also remove global operations in bundles
leofeyer
pushed a commit
to contao/news-bundle
that referenced
this pull request
Nov 14, 2023
Description ----------- Forgot to adjust bundles in contao/contao#6528 Commits ------- eba6e349 Also remove global operations in bundles
leofeyer
added a commit
that referenced
this pull request
Nov 22, 2023
Description ----------- This replaces our legacy `toggleStructure` and `toggleFileTree` to a universal Stimulus controller that implements the behaviour for both drivers. ~Additionally, it makes setting global operations optional because they can now be generated automatically. Might want to refactor this into a separate PR though.~ (see #6528) This changes the following behaviour: - DC_Folder previously started with `level 1` while DC_Table starts a tree at `level 0`. This has no been unified (always start at 0). It only affects `DC_Folder::ajaxTreeView()` argument, so I doubt this will be an issue. - The old code manually tried to replace the `ref` (referrer ID) in the URL with the current value. Because our framework generated a new referer ID on every request. It now keeps the current referer ID for ajax requests (if `ref` is given in the request). Commits ------- 5abb879 Added toggle nodes Stimulus controller afee87f Automatically generate global operations for all DCAs b8ee95d Deprecate the old Mootools functions b46211f Use loading spinner instead of ajax box e994702 Rewrite to vanilla JS 23a28c3 Fix duplicate listener after rebase 762b86e Added test for RefererIdListener 828ccf5 Drop obsolete test class a44b665 Rebuild the scripts Co-authored-by: leofeyer <1192057+leofeyer@users.noreply.github.com>
leofeyer
added a commit
to contao/core-bundle
that referenced
this pull request
Nov 22, 2023
Description ----------- This replaces our legacy `toggleStructure` and `toggleFileTree` to a universal Stimulus controller that implements the behaviour for both drivers. ~Additionally, it makes setting global operations optional because they can now be generated automatically. Might want to refactor this into a separate PR though.~ (see contao/contao#6528) This changes the following behaviour: - DC_Folder previously started with `level 1` while DC_Table starts a tree at `level 0`. This has no been unified (always start at 0). It only affects `DC_Folder::ajaxTreeView()` argument, so I doubt this will be an issue. - The old code manually tried to replace the `ref` (referrer ID) in the URL with the current value. Because our framework generated a new referer ID on every request. It now keeps the current referer ID for ajax requests (if `ref` is given in the request). Commits ------- 5abb8798 Added toggle nodes Stimulus controller afee87fe Automatically generate global operations for all DCAs b8ee95d5 Deprecate the old Mootools functions b46211ff Use loading spinner instead of ajax box e9947029 Rewrite to vanilla JS 23a28c31 Fix duplicate listener after rebase 762b86ed Added test for RefererIdListener 828ccf57 Drop obsolete test class a44b6656 Rebuild the scripts Co-authored-by: leofeyer <1192057+leofeyer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracted for #6527