Handle empty sessions in the CSRF cookie subscriber #6801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritzmg
reviewed
Jan 29, 2024
fritzmg
previously approved these changes
Jan 29, 2024
ausi
reviewed
Jan 29, 2024
ausi
previously approved these changes
Jan 29, 2024
fritzmg
previously approved these changes
Jan 29, 2024
leofeyer
approved these changes
Jan 29, 2024
leofeyer
changed the title
leofeyer
changed the title
|
Thank you @Toflar. |
|
Unfortunately, this breaks the Cypress tests: https://github.com/contao/contao/actions/runs/7711662213/job/21017463546
So maybe the changes are not correct? |
leofeyer
pushed a commit
that referenced
this pull request
Mar 5, 2024
leofeyer
pushed a commit
to contao/core-bundle
that referenced
this pull request
Mar 5, 2024
Description ----------- Same as contao/contao#6801 for the `MakeResponsePrivateListener`. Commits ------- 611dec17 Only make a response private if the session was not empty
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have some code that adds something to the session (and thus starts it) and some code that removes it again, our CsrfTokenCookieSubscriber would still add the CSRF cookie token as the session was started. This makes no sense if the session is empty, thus we need to add this check on top :)