Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not make a response private if the session is empty #6959

Merged
merged 1 commit into from Mar 5, 2024
Merged

Do not make a response private if the session is empty #6959

merged 1 commit into from Mar 5, 2024

Conversation

Toflar
Copy link
Member

@Toflar Toflar commented Mar 4, 2024

Same as #6801 for the MakeResponsePrivateListener.

@Toflar Toflar added the bug label Mar 4, 2024
@Toflar Toflar self-assigned this Mar 4, 2024
@Toflar Toflar added this to the 4.13 milestone Mar 4, 2024
@Toflar Toflar force-pushed the fix/make-response-private-listener-session-empty branch from 196d799 to 611dec1 Compare March 4, 2024 12:28
fritzmg
fritzmg reviewed Mar 4, 2024
View reviewed changes
Copy link
Contributor

@fritzmg fritzmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this also missing for the ContaoCsrfTokenManager?

@leofeyer leofeyer changed the title Only make a response private if the session was not empty Do not make a response private if the session is empty Mar 5, 2024
@leofeyer leofeyer merged commit 238af67 into contao:4.13 Mar 5, 2024
17 checks passed
@leofeyer
Copy link
Member

leofeyer commented Mar 5, 2024

Thank you @Toflar.

@leofeyer
Copy link
Member

leofeyer commented Mar 5, 2024

Isn't this also missing for the ContaoCsrfTokenManager?

I think so, too.

@Toflar Toflar deleted the fix/make-response-private-listener-session-empty branch March 5, 2024 12:30
@fritzmg fritzmg mentioned this pull request Mar 22, 2024
Closed
@leofeyer leofeyer mentioned this pull request Mar 22, 2024
Merged
@fmenzel
Copy link

fmenzel commented Apr 15, 2024 •
edited

Has this been applied to the ContaoCsrfTokenManager yet?

@fritzmg
Copy link
Contributor

fritzmg commented Apr 15, 2024

Yes, see #7052
But it has not been released yet.

@fritzmg fritzmg mentioned this pull request Apr 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fritzmg fritzmg fritzmg left review comments

@aschempp aschempp aschempp approved these changes

Assignees

@Toflar Toflar

Labels
bug
Projects
None yet
Milestone
4.13
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Toflar @leofeyer @fmenzel @fritzmg @aschempp