Decouple the locale subscriber test from the request implementation #7285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toflar
previously approved these changes
Jun 17, 2024
leofeyer
previously approved these changes
Jun 18, 2024
leofeyer
changed the title
|
Thank you @aschempp. |
leofeyer
force-pushed
the
fix/locale-subscriber
branch
from
eaa89ed
to
9fb9e79
Compare
leofeyer
approved these changes
Jun 18, 2024
leofeyer
added a commit
that referenced
this pull request
Jun 25, 2024
Description ----------- 5.3 LTS requires Symfony 6.4 LTS as per our roadmap. This means, Contao 5.4 must allow Symfony 7 components. Dependencies: - [x] `contao/manager-plugin`: contao/manager-plugin#56 - [x] `contao/image`: contao/image#104 - [x] `terminal42/service-annotation-bundle`: terminal42/service-annotation-bundle#9 - [x] `terminal42/escargot`: terminal42/escargot#36 - [x] Merge #7285 in `5.3`and then uptream into `5.x` Commits ------- 0aa8323 Allow Symfony 7 in all packages 277005c Update to nikic/php-parser v5 in order to fix PHP incompatiblity issues 1eb7d8b Fixed test incompatibilities a4eb15d Fixed DoctrineSchemaListener a19c436 Fixed phpstan af07922 Update calendar-bundle/composer.json 103d01e Update scheb/2fa bundles 01dca93 Fix interface incompatibility 15ebe55 Updated FOS HttpCache related dependencies d18e73b Apply suggestions from code review aef96c3 Fixed the LocaleSubscriberTest 5aef4aa Revert changes ade8393 Cleanup 0c2b171 Use the existing news bundle when installing the core bundle in the "… Co-authored-by: leofeyer <1192057+leofeyer@users.noreply.github.com>
leofeyer
added a commit
to contao/listing-bundle
that referenced
this pull request
Jun 25, 2024
Description ----------- 5.3 LTS requires Symfony 6.4 LTS as per our roadmap. This means, Contao 5.4 must allow Symfony 7 components. Dependencies: - [x] `contao/manager-plugin`: contao/manager-plugin#56 - [x] `contao/image`: contao/image#104 - [x] `terminal42/service-annotation-bundle`: terminal42/service-annotation-bundle#9 - [x] `terminal42/escargot`: terminal42/escargot#36 - [x] Merge contao/contao#7285 in `5.3`and then uptream into `5.x` Commits ------- 0aa8323a Allow Symfony 7 in all packages 277005c0 Update to nikic/php-parser v5 in order to fix PHP incompatiblity issues 1eb7d8b2 Fixed test incompatibilities a4eb15d6 Fixed DoctrineSchemaListener a19c436e Fixed phpstan af07922f Update calendar-bundle/composer.json 103d01e2 Update scheb/2fa bundles 01dca93a Fix interface incompatibility 15ebe558 Updated FOS HttpCache related dependencies d18e73bd Apply suggestions from code review aef96c3b Fixed the LocaleSubscriberTest 5aef4aad Revert changes ade83931 Cleanup 0c2b1713 Use the existing news bundle when installing the core bundle in the "… Co-authored-by: leofeyer <1192057+leofeyer@users.noreply.github.com>
leofeyer
added a commit
to contao/maker-bundle
that referenced
this pull request
Jun 25, 2024
Description ----------- 5.3 LTS requires Symfony 6.4 LTS as per our roadmap. This means, Contao 5.4 must allow Symfony 7 components. Dependencies: - [x] `contao/manager-plugin`: contao/manager-plugin#56 - [x] `contao/image`: contao/image#104 - [x] `terminal42/service-annotation-bundle`: terminal42/service-annotation-bundle#9 - [x] `terminal42/escargot`: terminal42/escargot#36 - [x] Merge contao/contao#7285 in `5.3`and then uptream into `5.x` Commits ------- 0aa8323a Allow Symfony 7 in all packages 277005c0 Update to nikic/php-parser v5 in order to fix PHP incompatiblity issues 1eb7d8b2 Fixed test incompatibilities a4eb15d6 Fixed DoctrineSchemaListener a19c436e Fixed phpstan af07922f Update calendar-bundle/composer.json 103d01e2 Update scheb/2fa bundles 01dca93a Fix interface incompatibility 15ebe558 Updated FOS HttpCache related dependencies d18e73bd Apply suggestions from code review aef96c3b Fixed the LocaleSubscriberTest 5aef4aad Revert changes ade83931 Cleanup 0c2b1713 Use the existing news bundle when installing the core bundle in the "… Co-authored-by: leofeyer <1192057+leofeyer@users.noreply.github.com>
leofeyer
added a commit
to contao/faq-bundle
that referenced
this pull request
Jun 25, 2024
Description ----------- 5.3 LTS requires Symfony 6.4 LTS as per our roadmap. This means, Contao 5.4 must allow Symfony 7 components. Dependencies: - [x] `contao/manager-plugin`: contao/manager-plugin#56 - [x] `contao/image`: contao/image#104 - [x] `terminal42/service-annotation-bundle`: terminal42/service-annotation-bundle#9 - [x] `terminal42/escargot`: terminal42/escargot#36 - [x] Merge contao/contao#7285 in `5.3`and then uptream into `5.x` Commits ------- 0aa8323a Allow Symfony 7 in all packages 277005c0 Update to nikic/php-parser v5 in order to fix PHP incompatiblity issues 1eb7d8b2 Fixed test incompatibilities a4eb15d6 Fixed DoctrineSchemaListener a19c436e Fixed phpstan af07922f Update calendar-bundle/composer.json 103d01e2 Update scheb/2fa bundles 01dca93a Fix interface incompatibility 15ebe558 Updated FOS HttpCache related dependencies d18e73bd Apply suggestions from code review aef96c3b Fixed the LocaleSubscriberTest 5aef4aad Revert changes ade83931 Cleanup 0c2b1713 Use the existing news bundle when installing the core bundle in the "… Co-authored-by: leofeyer <1192057+leofeyer@users.noreply.github.com>
leofeyer
added a commit
to contao/newsletter-bundle
that referenced
this pull request
Jun 25, 2024
Description ----------- 5.3 LTS requires Symfony 6.4 LTS as per our roadmap. This means, Contao 5.4 must allow Symfony 7 components. Dependencies: - [x] `contao/manager-plugin`: contao/manager-plugin#56 - [x] `contao/image`: contao/image#104 - [x] `terminal42/service-annotation-bundle`: terminal42/service-annotation-bundle#9 - [x] `terminal42/escargot`: terminal42/escargot#36 - [x] Merge contao/contao#7285 in `5.3`and then uptream into `5.x` Commits ------- 0aa8323a Allow Symfony 7 in all packages 277005c0 Update to nikic/php-parser v5 in order to fix PHP incompatiblity issues 1eb7d8b2 Fixed test incompatibilities a4eb15d6 Fixed DoctrineSchemaListener a19c436e Fixed phpstan af07922f Update calendar-bundle/composer.json 103d01e2 Update scheb/2fa bundles 01dca93a Fix interface incompatibility 15ebe558 Updated FOS HttpCache related dependencies d18e73bd Apply suggestions from code review aef96c3b Fixed the LocaleSubscriberTest 5aef4aad Revert changes ade83931 Cleanup 0c2b1713 Use the existing news bundle when installing the core bundle in the "… Co-authored-by: leofeyer <1192057+leofeyer@users.noreply.github.com>
leofeyer
added a commit
to contao/core-bundle
that referenced
this pull request
Jun 25, 2024
Description ----------- 5.3 LTS requires Symfony 6.4 LTS as per our roadmap. This means, Contao 5.4 must allow Symfony 7 components. Dependencies: - [x] `contao/manager-plugin`: contao/manager-plugin#56 - [x] `contao/image`: contao/image#104 - [x] `terminal42/service-annotation-bundle`: terminal42/service-annotation-bundle#9 - [x] `terminal42/escargot`: terminal42/escargot#36 - [x] Merge contao/contao#7285 in `5.3`and then uptream into `5.x` Commits ------- 0aa8323a Allow Symfony 7 in all packages 277005c0 Update to nikic/php-parser v5 in order to fix PHP incompatiblity issues 1eb7d8b2 Fixed test incompatibilities a4eb15d6 Fixed DoctrineSchemaListener a19c436e Fixed phpstan af07922f Update calendar-bundle/composer.json 103d01e2 Update scheb/2fa bundles 01dca93a Fix interface incompatibility 15ebe558 Updated FOS HttpCache related dependencies d18e73bd Apply suggestions from code review aef96c3b Fixed the LocaleSubscriberTest 5aef4aad Revert changes ade83931 Cleanup 0c2b1713 Use the existing news bundle when installing the core bundle in the "… Co-authored-by: leofeyer <1192057+leofeyer@users.noreply.github.com>
leofeyer
added a commit
to contao/test-case
that referenced
this pull request
Jun 25, 2024
Description ----------- 5.3 LTS requires Symfony 6.4 LTS as per our roadmap. This means, Contao 5.4 must allow Symfony 7 components. Dependencies: - [x] `contao/manager-plugin`: contao/manager-plugin#56 - [x] `contao/image`: contao/image#104 - [x] `terminal42/service-annotation-bundle`: terminal42/service-annotation-bundle#9 - [x] `terminal42/escargot`: terminal42/escargot#36 - [x] Merge contao/contao#7285 in `5.3`and then uptream into `5.x` Commits ------- 0aa8323a Allow Symfony 7 in all packages 277005c0 Update to nikic/php-parser v5 in order to fix PHP incompatiblity issues 1eb7d8b2 Fixed test incompatibilities a4eb15d6 Fixed DoctrineSchemaListener a19c436e Fixed phpstan af07922f Update calendar-bundle/composer.json 103d01e2 Update scheb/2fa bundles 01dca93a Fix interface incompatibility 15ebe558 Updated FOS HttpCache related dependencies d18e73bd Apply suggestions from code review aef96c3b Fixed the LocaleSubscriberTest 5aef4aad Revert changes ade83931 Cleanup 0c2b1713 Use the existing news bundle when installing the core bundle in the "… Co-authored-by: leofeyer <1192057+leofeyer@users.noreply.github.com>
leofeyer
added a commit
to contao/calendar-bundle
that referenced
this pull request
Jun 25, 2024
Description ----------- 5.3 LTS requires Symfony 6.4 LTS as per our roadmap. This means, Contao 5.4 must allow Symfony 7 components. Dependencies: - [x] `contao/manager-plugin`: contao/manager-plugin#56 - [x] `contao/image`: contao/image#104 - [x] `terminal42/service-annotation-bundle`: terminal42/service-annotation-bundle#9 - [x] `terminal42/escargot`: terminal42/escargot#36 - [x] Merge contao/contao#7285 in `5.3`and then uptream into `5.x` Commits ------- 0aa8323a Allow Symfony 7 in all packages 277005c0 Update to nikic/php-parser v5 in order to fix PHP incompatiblity issues 1eb7d8b2 Fixed test incompatibilities a4eb15d6 Fixed DoctrineSchemaListener a19c436e Fixed phpstan af07922f Update calendar-bundle/composer.json 103d01e2 Update scheb/2fa bundles 01dca93a Fix interface incompatibility 15ebe558 Updated FOS HttpCache related dependencies d18e73bd Apply suggestions from code review aef96c3b Fixed the LocaleSubscriberTest 5aef4aad Revert changes ade83931 Cleanup 0c2b1713 Use the existing news bundle when installing the core bundle in the "… Co-authored-by: leofeyer <1192057+leofeyer@users.noreply.github.com>
leofeyer
added a commit
to contao/manager-bundle
that referenced
this pull request
Jun 25, 2024
Description ----------- 5.3 LTS requires Symfony 6.4 LTS as per our roadmap. This means, Contao 5.4 must allow Symfony 7 components. Dependencies: - [x] `contao/manager-plugin`: contao/manager-plugin#56 - [x] `contao/image`: contao/image#104 - [x] `terminal42/service-annotation-bundle`: terminal42/service-annotation-bundle#9 - [x] `terminal42/escargot`: terminal42/escargot#36 - [x] Merge contao/contao#7285 in `5.3`and then uptream into `5.x` Commits ------- 0aa8323a Allow Symfony 7 in all packages 277005c0 Update to nikic/php-parser v5 in order to fix PHP incompatiblity issues 1eb7d8b2 Fixed test incompatibilities a4eb15d6 Fixed DoctrineSchemaListener a19c436e Fixed phpstan af07922f Update calendar-bundle/composer.json 103d01e2 Update scheb/2fa bundles 01dca93a Fix interface incompatibility 15ebe558 Updated FOS HttpCache related dependencies d18e73bd Apply suggestions from code review aef96c3b Fixed the LocaleSubscriberTest 5aef4aad Revert changes ade83931 Cleanup 0c2b1713 Use the existing news bundle when installing the core bundle in the "… Co-authored-by: leofeyer <1192057+leofeyer@users.noreply.github.com>
leofeyer
added a commit
to contao/news-bundle
that referenced
this pull request
Jun 25, 2024
Description ----------- 5.3 LTS requires Symfony 6.4 LTS as per our roadmap. This means, Contao 5.4 must allow Symfony 7 components. Dependencies: - [x] `contao/manager-plugin`: contao/manager-plugin#56 - [x] `contao/image`: contao/image#104 - [x] `terminal42/service-annotation-bundle`: terminal42/service-annotation-bundle#9 - [x] `terminal42/escargot`: terminal42/escargot#36 - [x] Merge contao/contao#7285 in `5.3`and then uptream into `5.x` Commits ------- 0aa8323a Allow Symfony 7 in all packages 277005c0 Update to nikic/php-parser v5 in order to fix PHP incompatiblity issues 1eb7d8b2 Fixed test incompatibilities a4eb15d6 Fixed DoctrineSchemaListener a19c436e Fixed phpstan af07922f Update calendar-bundle/composer.json 103d01e2 Update scheb/2fa bundles 01dca93a Fix interface incompatibility 15ebe558 Updated FOS HttpCache related dependencies d18e73bd Apply suggestions from code review aef96c3b Fixed the LocaleSubscriberTest 5aef4aad Revert changes ade83931 Cleanup 0c2b1713 Use the existing news bundle when installing the core bundle in the "… Co-authored-by: leofeyer <1192057+leofeyer@users.noreply.github.com>
leofeyer
added a commit
to contao/comments-bundle
that referenced
this pull request
Jun 25, 2024
Description ----------- 5.3 LTS requires Symfony 6.4 LTS as per our roadmap. This means, Contao 5.4 must allow Symfony 7 components. Dependencies: - [x] `contao/manager-plugin`: contao/manager-plugin#56 - [x] `contao/image`: contao/image#104 - [x] `terminal42/service-annotation-bundle`: terminal42/service-annotation-bundle#9 - [x] `terminal42/escargot`: terminal42/escargot#36 - [x] Merge contao/contao#7285 in `5.3`and then uptream into `5.x` Commits ------- 0aa8323a Allow Symfony 7 in all packages 277005c0 Update to nikic/php-parser v5 in order to fix PHP incompatiblity issues 1eb7d8b2 Fixed test incompatibilities a4eb15d6 Fixed DoctrineSchemaListener a19c436e Fixed phpstan af07922f Update calendar-bundle/composer.json 103d01e2 Update scheb/2fa bundles 01dca93a Fix interface incompatibility 15ebe558 Updated FOS HttpCache related dependencies d18e73bd Apply suggestions from code review aef96c3b Fixed the LocaleSubscriberTest 5aef4aad Revert changes ade83931 Cleanup 0c2b1713 Use the existing news bundle when installing the core bundle in the "… Co-authored-by: leofeyer <1192057+leofeyer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LocaleSubscriperTest should not test the implementation details of the Request class. Fixes issues with #7279