Rework the front end preview #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toflar
reviewed
Nov 15, 2019
richardhj
commented
Nov 15, 2019
aschempp
reviewed
Nov 18, 2019
richardhj
changed the title
richardhj
changed the title
xchs
reviewed
Nov 24, 2019
core-bundle/src/Resources/views/FrontendPreview/authenticator.html.twig
Outdated
Show resolved
Hide resolved
richardhj
force-pushed
the
feature/preview
branch
from
a426da7
to
aaf3052
Compare
richardhj
force-pushed
the
feature/preview
branch
from
aaf3052
to
414b966
Compare
richardhj
changed the title
Toflar
reviewed
Nov 25, 2019
There was a problem hiding this comment.
Looks excellent to me. Imho, this can be extended with unit tests and merged as is!
Polishing CSS and adding more toolbar functionality such as JS can still be done afterwards. At least we got rid of the iframe now and the preview bar is shown consistently everywhere :) Great work!
ausi
reviewed
Nov 25, 2019
Co-Authored-By: Martin Auswöger <martin@auswoeger.com>
aschempp
reviewed
Nov 25, 2019
richardhj
force-pushed
the
feature/preview
branch
from
9434896
to
6fae43a
Compare
aschempp
requested changes
Dec 20, 2019
#1120 has been merged, so this can be added now. 👍 |
# Conflicts: # calendar-bundle/tests/DependencyInjection/ContaoCalendarExtensionTest.php # calendar-bundle/tests/EventListener/PreviewUrlConverterListenerTest.php # core-bundle/src/Resources/contao/library/Contao/User.php # news-bundle/tests/DependencyInjection/ContaoNewsExtensionTest.php # news-bundle/tests/EventListener/PreviewUrlConverterListenerTest.php
richardhj
force-pushed
the
feature/preview
branch
from
2e6aa15
to
2c1c97d
Compare
|
I addressed the changes and merged against master to resolve conflicts. |
aschempp
previously approved these changes
Jan 6, 2020
leofeyer
requested changes
Jan 6, 2020
leofeyer
force-pushed
the
feature/preview
branch
from
06899aa
to
1371041
Compare
Toflar
requested changes
Jan 6, 2020
richardhj
force-pushed
the
feature/preview
branch
from
ae12b74
to
b225e1d
Compare
Toflar
previously approved these changes
Jan 6, 2020
leofeyer
approved these changes
Jan 6, 2020
|
Thank you @richardhj. 🎉 |
|
🎉 thanks, Richard! ❤️ |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR injects the back end preview bar and replaces the preview frameset.
How this works:
The preview bar is injected into the DOM on
kernel.responseevent.When the user wants to view the page as a member, an Ajax request is triggered in which the preview authentication will be handled. The Ajax endpoint logs in the user, returns an HTTP OK and finally, a page reload is done.
TODO:
Impressions:
Outlook:
I already worked on an enhanced version of the preview. Once this PR is approved and merged, I add a framework for 3rd parties to add content to the preview toolbar.
So-called "preview providers" (class must implementing an interface and tag the service with
contao.preview_provider) can add arbitrary content to the toolbar.In the end, the great advantage of the preview is the back end scope in the front end.
The toolbar should be either horizontally (as we know it) or left-aligned when the content requires it.
Use case: theme switch or changing CSS variables on runtime.