Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TL_CSS needs to be prefixed with “web/” for combined CSS files #300

Closed
ausi opened this issue Jun 12, 2015 · 4 comments
Closed

TL_CSS needs to be prefixed with “web/” for combined CSS files #300

ausi opened this issue Jun 12, 2015 · 4 comments
Assignees
@leofeyer
Labels
bug
Milestone
4.0

Comments

@ausi
Copy link
Member

ausi commented Jun 12, 2015

If you add a stylesheet via $GLOBALS['TL_CSS']:

// Works always
$GLOBALS['TL_CSS'][] = 'bundles/mybundle/file.css';

// Doesn’t work if not in debug mode
$GLOBALS['TL_CSS'][] = 'bundles/mybundle/file.css|static';

// Always doesn’t work
$GLOBALS['TL_CSS'][] = 'web/bundles/mybundle/file.css';

// Works if not in debug mode
$GLOBALS['TL_CSS'][] = 'web/bundles/mybundle/file.css|static';
@aschempp
Copy link
Member

The problem probably is the file_exists check. Path without /web would be correct.

@leofeyer leofeyer added the bug label Jul 20, 2015
@leofeyer leofeyer added this to the 4.0.1 milestone Jul 20, 2015
leofeyer added a commit that referenced this issue Jul 23, 2015
@leofeyer
Correctly handle files in the /web directory in the Combiner (see #300
dd2fa41 
).
@leofeyer
Copy link
Member

Fixed in dd2fa41.

@aschempp
Copy link
Member

Repeating ourselves again… please do not commit changes that do not belong together…

@leofeyer
Copy link
Member

These changes belong together. What's your problem?

leofeyer added a commit that referenced this issue Jul 23, 2015
@leofeyer
Correctly handle files in the /web directory in the Combiner (see #300
6b9f4c8 
).
@leofeyer leofeyer self-assigned this Jul 24, 2015
@ausi ausi mentioned this issue Jun 18, 2018
Merged
leofeyer pushed a commit that referenced this issue May 9, 2019
@fritzmg @leofeyer
Add a splash image to the Vimeo and YouTube elements (see #300)
1c57017 
Description
-----------

One of the more frequently requested features for Contao 4.6 and up from the https://github.com/friends-of-contao/contao-privacy extension is the ability to use a splash image for YouTube and Vimeo video elements, to prevent client connections to these services upon visiting the Contao website.

Since the future of that extension regarding Contao 4.6 and up is unclear, I think it would make sense to integrate this feature into the core.

![screenshot_2019-01-26 articles home content elements edit content element id 11 - contao open source cms](https://user-images.githubusercontent.com/4970961/51789660-878f5880-218b-11e9-8ce9-cf7e7fee6fa0.png)

Commits
-------

98fb89ac add splash image to vimeo & youtube elements
7fd82d62 use a for splash image wrapper
6867aa8d remove class and streamline JS
abba23c4 Merge remote-tracking branch 'upstream/master' into feature/video-splash-image
f3900734 fix videoSplash template variable assignment
62467a1d Rename "videoSplash" to "splashImage"
736cad76 Add the splash image legend language string
@leofeyer leofeyer modified the milestones: 4.0.3, 4.0 May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leofeyer leofeyer

Labels
bug
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
3 participants
@ausi @aschempp @leofeyer