Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace custom config files with app/Resources #314

Closed
aschempp opened this issue Jul 21, 2015 · 11 comments
Closed

Replace custom config files with app/Resources #314

aschempp opened this issue Jul 21, 2015 · 11 comments
Assignees
@leofeyer
Labels
feature
Milestone
4.1

Comments

@aschempp
Copy link
Member

We should replace dcaconfig.php and langconfig.php with app/Resources/contao/…. This way we can drop the two files in Contao 5 or so.

"Replacing" probably means updating the manual and notice in the files, as well as adding deprecation info into our document files.
@leofeyer
Copy link
Member

leofeyer commented Aug 6, 2015

Would make sense if we also moved the localconfig.php file there.

@aschempp
Copy link
Member Author

aschempp commented Aug 7, 2015

Well I would not move the existing files, because they are "legacy". The new config obviously already is in app/Resources/, same as the parameters.yaml

@leofeyer
Copy link
Member

leofeyer commented Aug 9, 2015

So localconfig.php is legacy but dcaconfig.php and langconfig.php are not?

@aschempp
Copy link
Member Author

aschempp commented Aug 9, 2015

No, you got me wrong. People should not add a dcaconfig.php. The should add a file to app/Resources/contao/dca/tl_user.php if they want to modify the tl_user DCA.

@leofeyer
Copy link
Member

Ah, ok, +1 then.

@leofeyer leofeyer added this to the 4.1.0 milestone Aug 10, 2015
leofeyer added a commit that referenced this issue Aug 25, 2015
@leofeyer
Support overwriting resources in app/Resources/contao (see #314).
adec51d
@leofeyer
Copy link
Member

Added in adec51d.

@leofeyer leofeyer self-assigned this Aug 25, 2015
leofeyer pushed a commit that referenced this issue Feb 19, 2019
@bytehead @leofeyer
Hide the impersonation link if already in impersonation mode (see #345)
701b8d1 
Description
-----------

Fixes #314.

Commits
-------

940b1b36 Hide impersonation link if already in impersonation mode
c04b7b46 Merge the two if statements
@Riveryuan
Copy link

I want add a field to tl_content named 'itemData', I created file: app/src/Resources/contao/dca/tl_content.php, but this file not loaded..........

@Riveryuan
Copy link

No, you got me wrong. People should not add a dcaconfig.php. The should add a file to app/Resources/contao/dca/tl_user.php if they want to modify the tl_user DCA.

Not working.......
I tried
app/src/Resources......
app/Resources......

@fiedsch
Copy link
Contributor

fiedsch commented Aug 20, 2019

Did you clear the cache after you made the changes?

@Riveryuan
Copy link

I tried "contao-console cache:clear", it's working!
Thank you!

@leofeyer
Copy link
Member

@Riveryuan Please do not hijack existing tickets but create a new one instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leofeyer leofeyer

Labels
feature
Projects
None yet
Milestone
4.1
Development

No branches or pull requests
4 participants
@aschempp @leofeyer @fiedsch @Riveryuan