New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
including the same form multiple times creates duplicate CSS-IDs #957
Comments
I think this is related to contao/core#8538 (comment) |
Hm, yes I thought so too, I wasn't sure though since the original issues was about the page cache. |
Fixed in bd3c749. |
This is not fixed completely. Including the same form multiple times on a page will still cause duplicate CSS-IDs. While it is fixed for the CSS-ID of the <input name="email" id="ctrl_1" class="text mandatory" value="" placeholder="Email …" required="" type="email">
…
<input name="email" id="ctrl_1" class="text mandatory" value="" placeholder="Email …" required="" type="email"> |
@contao/developers I think changing the form field IDs is a BC break, isn't it? The ID could be used in a CSS or JS selector. Then again we have removed the default form ID … 😄 |
Indeed. I know of at least one extension that relies on the form field CSS IDs. Could it be done for Contao 4.5? |
I guess it's just a known limitation that you cannot use the very same form on the same page. The |
Description ----------- This will make the coverage check results appear more quickly. Also, it is another step towards moving from Travis to GitHub actions. Commits ------- 75d0c42a Add a GitHub action to create the coverage reports fa8586cd Run the CS fixer
If you include the same form multiple times on a page, each form will get the same CSS-ID, e.g.
id="f1"
.Though I wonder now, is inserting the same form multiple times on the same page (i.e. once in the header and once in the footer) not a supported use case?
The text was updated successfully, but these errors were encountered: