New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Favicon in backend causes usability glitches #958
Comments
I agree, I also get confused now while having the community forums and multiple contao backends open within the same browser window. |
You can simply change the be_main.html5 template (change/delete the favicon link) Just an idea: Make the contao favicon for the backend without color (a grey icon)?! |
You would have to override the complete <?php $this->block('favicon'); ?>
<link rel="icon" type="image/png" href="<?= TL_ASSETS_URL ?>bundles/contaocore/favicon.ico">
<?php $this->endblock(); ?>
Yeah, I'd like that too - but also make it configurable (either via a setting or via a template block). |
Why the 'complete' template? Just the favicon line.. |
No, you have to override the complete template, because there are no template blocks defined. With template blocks your own <?php $this->extend('be_main'); ?>
<?php $this->block('favicon'); ?>
<link rel="icon" type="image/png" href="<?= TL_ASSETS_URL ?>path/to/your/favicon.ico">
<?php $this->endblock(); ?> |
Can I extend the same template (name) itself? I know the way to extend the 'block_searchable' a.s.o. but never extended the origin template itself without changing the name. |
Yes, you can do that (but only in the |
You never stop learning..
Is there a source for recommendation? |
It is inherently recommended ;). If you don't have to override a template completely, you won't miss out on any updates to the parent template. Another example: if you want to add additional meta tags to the <?php $this->extend('fe_page'); ?>
<?php $this->block('meta'); ?>
<?php $this->parent(); ?>
<meta name="og:type" content="website">
<?php $this->endblock(); ?> Also you don't need to specifically select the changed template, if the name is the same as the original. |
Removed in ad7b624. |
Why not using a different favicon? |
Because three backends mean that there will be three lookalike favicons, which is in fact not useful. You should be able to control this behaviour, setting individual icons. After removing the code, you are able to do so by simply placing an icon at root level and putting another icon for the frontend into your layout. |
Ok. I understand. IMO that looks like the easiest way to do. |
It seems the orange favicon has been re-added in Contao 4.5-beta3 (Managed Edition). Was this done deliberately? |
Why not simply add a favicon.ico to the root? There has to be no code in the HEAD. A year ago I created a pull request to https://github.com/Ma3xl3/Contao-EasyFavicon. When this will get merged everyone who uses EasyFavicon can easily add the chosen favicon for FE also to the BE by activating a checkbox. |
@fritzmg What exactly do you mean? |
Execute
There will be a It has been added here: contao/manager-bundle@aa4e4e4 |
That's fine. The issue in this ticket was a different one. |
Yeah I realize that now. But still, do we want to have this? Now I have to delete it with every new Contao installation. It's only a minor nuissance, but still. |
Deleting the
Instead, one has to replace it with another |
If I understand the code right after a first short look, the favicon is only added of none exists. Same for the .htaccess file. So you're forced now to add a custom one of you don't want to see the Contao icon. That's fine with me |
Yes, that's why I wrote
However, that's still a little annoying. Implementing the favicon isn't usually the first thing that happens during the development of a website - and if you don't do that, then you got the original problem of this ticket. So if there's got to be a default |
Description ----------- | Q | A | -----------------| --- | Fixed issues | Fixes #958 | Docs PR or issue | - <!-- Bugfixes should be based on the 4.4 or 4.9 branch and features on the master branch. Select the correct branch in the "base:" drop-down menu above. Replace this notice with a short README for your feature/bugfix. This will help people to understand your PR and can be used as a start for the documentation. --> Commits ------- 6b398b20 Set "information_schema_stats_expiry=0" in MySQL 8
In b311944 a separate icon for the backend was introduced which causes usability glitches.
I am completely fine with an option showing a backend icon, showing love and prideness for Contao, BUT since I often work in multiple backends at the same time, the community forums are open at the same time in browser and still the Contao project page is open more or less generally AND they all use the same icon now, I just find this not only confusing but annoying.
Shouldn't this be configurable?
The text was updated successfully, but these errors were encountered: