[RFC] (Re)add a grey favicon for the backend #963
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritzmg
reviewed
Jul 14, 2017
| @@ -9,6 +9,9 @@ | |||
| <meta name="viewport" content="width=device-width,initial-scale=1.0,shrink-to-fit=no"> | |||
| <meta name="referrer" content="origin"> | |||
|
|
|||
| <?php $this->block('favicon'); ?> | |||
| <link rel="icon" type="image/png" href="<?= TL_ASSETS_URL ?>bundles/contaocore/favicon.ico"> | |||
| <?php $this->endblock(); ?> | |||
There was a problem hiding this comment.
This block should be indented by two spaces.
|
We have discussed this in Mumble yesterday and agreed that the back end should show the favicon that is in the document root. |
Ah, sorry. I didn't know that. |
|
@agoat you could create a PR to introduce template blocks into the back end templates instead. e.g. …
<head>
<meta charset="<?= $this->charset ?>">
<title><?= $this->title ?> - Contao Open Source CMS</title>
<base href="<?= $this->base ?>">
<?php $this->block('meta'); ?>
<meta name="generator" content="Contao Open Source CMS">
<meta name="viewport" content="width=device-width,initial-scale=1.0,shrink-to-fit=no">
<meta name="referrer" content="origin">
<?php $this->endblock(); ?>
<?php $this->block('stylesheets'); ?>
<link rel="stylesheet" href="<?= TL_ASSETS_URL ?>system/themes/<?= $this->theme ?>/fonts.css">
<link rel="stylesheet" href="<?= TL_ASSETS_URL ?>assets/colorpicker/css/mooRainbow.min.css">
<link rel="stylesheet" href="<?= TL_ASSETS_URL ?>assets/chosen/css/chosen.min.css">
<link rel="stylesheet" href="<?= TL_ASSETS_URL ?>assets/simplemodal/css/simplemodal.min.css">
<link rel="stylesheet" href="<?= TL_ASSETS_URL ?>assets/datepicker/css/datepicker.min.css">
<link rel="stylesheet" href="<?= TL_ASSETS_URL ?>system/themes/<?= $this->theme ?>/basic.css">
<link rel="stylesheet" href="<?= TL_ASSETS_URL ?>system/themes/<?= $this->theme ?>/main.css">
<?= $this->stylesheets ?>
<?php $this->endblock(); ?>
<?php $this->block('javascripts'); ?>
<script><?= $this->getLocaleString() ?></script>
<script src="<?= TL_ASSETS_URL ?>assets/mootools/js/mootools.min.js"></script>
<script src="<?= TL_ASSETS_URL ?>assets/colorpicker/js/mooRainbow.min.js"></script>
<script src="<?= TL_ASSETS_URL ?>assets/chosen/js/chosen.min.js"></script>
<script src="<?= TL_ASSETS_URL ?>assets/simplemodal/js/simplemodal.min.js"></script>
<script src="<?= TL_ASSETS_URL ?>assets/datepicker/js/datepicker.min.js"></script>
<script src="<?= TL_ASSETS_URL ?>bundles/contaocore/mootao.min.js"></script>
<script src="<?= TL_ASSETS_URL ?>bundles/contaocore/core.min.js"></script>
<script src="<?= TL_ASSETS_URL ?>system/themes/<?= $this->theme ?>/hover.js"></script>
<script><?= $this->getDateString() ?></script>
<?= $this->javascripts ?>
<?php $this->endblock(); ?>
</head>
…This way you could create your own <?php $this->extend('be_main'); ?>
<?php $this->block('stylesheets'); ?>
<link rel="icon" type="image/png" href="<?= TL_ASSETS_URL ?>path/to/your/backend/favicon.ico">
<?php $this->parent(); ?>
<?php $this->endblock(); ?>for example, if you still want to have a custom backend favicon. |
I think I will go with the document root solution for now and copy my grey icon there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I liked the backend icon. I want to (re)add this as it was removed in ad7b624.
Some people get confused to the same orange icon for the contao, community and backend pages (#958). So I made the icon grey to differ from the other pages.