Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Class "active" not set for initially opened accordion #7622

Closed
wangaz opened this issue Feb 5, 2015 · 4 comments
Closed

Class "active" not set for initially opened accordion #7622

wangaz opened this issue Feb 5, 2015 · 4 comments
Labels
Milestone

Comments

@wangaz
Copy link

wangaz commented Feb 5, 2015

Visit http://demo.contao.org/en/accordion.html. The headline Accordion single element is not printed in orange because class active does not have been set to the corresponding div.toggler.

@Aybee
Copy link
Contributor

Aybee commented Feb 6, 2015

I think this belongs to the COD https://github.com/contao/official-demo

There already are some classes on different states.

active
ui-accordion-header-active
ui-state-active

@wangaz
Copy link
Author

wangaz commented Feb 6, 2015

You are right that there are a number of classes set by the jQuery accordion script but the class active is set explicitly by Contao. Therefore, in my opinion, it should be set initially as well so that developers can rely on it.

@Aybee
Copy link
Contributor

Aybee commented Feb 6, 2015

Ok, I see. The active class is only set by clicking or keypress 13. It also has to be set on init to opened accordion item.

@leofeyer leofeyer added the defect label Feb 6, 2015
@leofeyer leofeyer added this to the 3.2.19 milestone Feb 6, 2015
@leofeyer
Copy link
Member

Fixed in 086ac61.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants