Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

validImageTypes for tl_content image #7702

Closed
DVeris opened this issue Mar 19, 2015 · 10 comments
Closed

validImageTypes for tl_content image #7702

DVeris opened this issue Mar 19, 2015 · 10 comments
Assignees
@leofeyer
Labels
defect
Milestone
3.5.22

Comments

@DVeris
Copy link

DVeris commented Mar 19, 2015

singleSRC (for image) has no validImageTypes in tl_content
and it is possible to select a file instead of the image

maybe add imgsingleSRC for images?
@leofeyer
Copy link
Member

This issue has been fixed meanwhile.

@KaiserCh
Copy link

This error still exists in v3.5.19 and is reproduceable in the online demo. In ce_text, you can select any file type for the "image" field, e.g. the .html file from the tinymce template folder.

@leofeyer leofeyer added this to the 3.5.19 milestone Nov 23, 2016
@leofeyer leofeyer reopened this Nov 23, 2016
@leofeyer leofeyer modified the milestones: 3.5.19, 3.5.20 Nov 23, 2016
@leofeyer
Copy link
Member

It actually works for me in the online demo. (?)

bildschirmfoto 2016-12-16 um 15 59 32

@Aybee
Copy link
Contributor

Aybee commented Dec 16, 2016 •
edited
Loading

I can confirm this bug in online demo 3.5.18 and 3.5.19. @leofeyer please open a folder which contains others than image files. Then you will see that you can select e.g. an html or js file.

@KaiserCh
Copy link

Like Aybee said: content-images contains only images, thats the one folder you shouldn't use for testing. Just go down one folder to documents. You'll be able to select the pdf. Or take index.html file from the tiny_templates folder.

@leofeyer
Copy link
Member

Nope, sorry. Here is a screenshot of the picker in a downloads element:

1

And here is a screenshot of the picker in a text element in the "add image" section:

2

As you can clearly see, the non-image files are not shown in the second screenshot.

@KaiserCh
Copy link

Well, the PDF was selectable when I wrote the last message. Now it is not.
But check out this screenshot. While I can't access the PDF, I can still access the index.html. Well.. I could. Now, it's impossible. The accessible file types (or files?) change from reload to reload. Maybe something in the Cookies...

ce_text-image-bug

@leofeyer
Copy link
Member

The accessible file types (or files?) change from reload to reload.

Can you reliably reproduce this?

@KaiserCh
Copy link

I think I've found a way to reliably reproduce this bug. It depends on the folder status.
If the folder is closed when the file dialog is opened, you can select any file type inside this folder. If the folder is already opened/expanded when calling the file picker, you can only pick images.

@leofeyer leofeyer modified the milestones: 3.5.20, 3.5.21 Dec 19, 2016
leofeyer added a commit that referenced this issue Jan 5, 2017
@leofeyer
Call the load callback when loading page/file picker nodes (see #7702).
7b7af71
@leofeyer
Copy link
Member

leofeyer commented Jan 5, 2017

Fixed in 7b7af71.

@leofeyer leofeyer closed this as completed Jan 5, 2017
@leofeyer leofeyer modified the milestones: 3.5.22, 3.5.21 Jan 5, 2017
@leofeyer leofeyer self-assigned this Jan 5, 2017
leofeyer added a commit that referenced this issue Jan 16, 2017
@leofeyer
Call the load callback when loading page/file picker nodes (see #7702).
587265e
jsonn pushed a commit to jsonn/pkgsrc that referenced this issue Jan 20, 2017
Update contao43 to 4.3.3.
92da689 
 * Correctly handle nested public folders when symlinking a folder.
 * Correctly handle SVGZ files in the file manager (see contao/core#8624).
 * Prevent an endless redirect loop if the page alias is "/" (see contao/core#8560).
 * Correctly parse German dates with two digit years in MooTools (see contao/core#8593).
 * Correctly add new resources to the user/group permissions (see contao/core#8583).
 * Trigger the auto-submit function in the date picker (see contao/core#8603).
 * Call the load callback when loading page/file picker nodes (see contao/core#7702).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@leofeyer leofeyer

Labels
defect
Projects
None yet
Milestone
3.5.22
Development

No branches or pull requests
4 participants
@Aybee @leofeyer @DVeris @KaiserCh