reduce memory consumption during sitemap generation #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 9, 2018
Toflar
approved these changes
Jun 11, 2018
|
Thank you @fritzmg. |
leofeyer
pushed a commit
to contao/faq-bundle
that referenced
this pull request
Jun 13, 2018
Description ----------- See contao/news-bundle#37 Commits ------- 5309dac reduce memory consumption during sitemap generation
leofeyer
pushed a commit
to contao/comments-bundle
that referenced
this pull request
Jun 13, 2018
Description ----------- If a page shows a lot of comments with a lot of back end user replies, the memory consumption could potentiallly be higher than needed. However, this problem should not be as severe as contao/news-bundle#37 Commits ------- 77a36be reduce memory consumption
leofeyer
pushed a commit
to contao/calendar-bundle
that referenced
this pull request
Jun 13, 2018
Description ----------- See contao/news-bundle#37 Commits ------- e5ada9e reduce memory consumption during sitemap generation (contao/core-bundle#1157)
leofeyer
pushed a commit
to contao/core-bundle
that referenced
this pull request
Jun 13, 2018
Description ----------- See contao/news-bundle#37 Commits ------- c80024b reduce memory consumption during sitemap generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See contao/core-bundle#1157
The issue is the following:
Models.Model.'load'=>'eager'on theauthorandpidoftl_newsandtl_calendar_eventsthis results in a large memory consumption, since the author and archive/calendar is duplicated in memory for each news entry.lazy.Comparison: when using 10.000 news entries the peak memory usage would be around 1.4 GiB when loading them all. After these changes the peak memory usage is only around 60 MiB.