This repository has been archived by the owner on Sep 1, 2023. It is now read-only.
[RFC] Fix classloading error when using contao/phpstan in contao based projects #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bytehead
changed the title
leofeyer
reviewed
Aug 16, 2019
| @@ -40,7 +40,8 @@ | |||
| }, | |||
| "autoload": { | |||
| "psr-4": { | |||
| "Contao\\PhpStan\\": "src/" | |||
| "Contao\\PhpStan\\": "src/", | |||
| "Contao\\CoreBundle\\Tests\\": "../../contao/core-bundle/tests/" | |||
There was a problem hiding this comment.
Do we not have to remove the entry from autoload-dev then?
There was a problem hiding this comment.
I think we need autoload-dev for contao/phpstan itself in test environments.
My added line only will provide autoload information if you use contao/phpstan in your project.
If you remove it, the tests for contao/phpstan will fail with the same error message as in contao/contao#627.
There was a problem hiding this comment.
I see. Then I guess the solution is fine. @aschempp WDYT?
There was a problem hiding this comment.
Will it work with contao/contao and contao/core-bundle installed?
|
Thank you @bytehead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be a possible fix for contao/contao#627.