This repository was archived by the owner on Sep 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Add a kernel again #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofeyer
reviewed
Jan 21, 2020
leofeyer
reviewed
Jan 21, 2020
leofeyer
reviewed
Jan 21, 2020
leofeyer
approved these changes
Jan 21, 2020
Member
|
I thought we did not want to merge this and keep using the external kernel so we do not have to maintain the config.yml and security.yml files in several different places? |
Member
Author
|
The master build failed because of contao/contao#762. But I can revert it if you want. The config.yml and security.yml don't change that much IMO. |
Member
|
I think the correct fix for that would be to install from source instead from dist: "config": {
"preferred-install": {
"contao/*": "source",
"*": "dist"
}
}, |
Member
Author
|
Revert PR: #13 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it's gone for
prefer-distinstallations: contao/contao#762.It also reverts #6.
Should be released as a new feature release
0.13.0while Contao4.9.0is released.To-Do:
"contao/core-bundle": "^4.9"