Skip to content
This repository was archived by the owner on Sep 1, 2023. It is now read-only.

Conversation

@bytehead
Copy link
Member

@bytehead bytehead commented Jan 19, 2020

Because it's gone for prefer-dist installations: contao/contao#762.

It also reverts #6.

Should be released as a new feature release 0.13.0 while Contao 4.9.0 is released.

To-Do:

  • Update Composer constraint to "contao/core-bundle": "^4.9"

@bytehead bytehead self-assigned this Jan 19, 2020
@bytehead bytehead added the bug Something isn't working label Jan 19, 2020
@bytehead bytehead requested a review from leofeyer January 19, 2020 14:59
@bytehead bytehead added enhancement New feature or request and removed bug Something isn't working labels Jan 21, 2020
@bytehead bytehead merged commit 07ab15c into contao:master Mar 4, 2020
@bytehead bytehead deleted the bugfix/add-kernel branch March 4, 2020 10:31
@leofeyer
Copy link
Member

leofeyer commented Mar 5, 2020

I thought we did not want to merge this and keep using the external kernel so we do not have to maintain the config.yml and security.yml files in several different places?

@bytehead
Copy link
Member Author

bytehead commented Mar 5, 2020

The master build failed because of contao/contao#762. But I can revert it if you want. The config.yml and security.yml don't change that much IMO.

@leofeyer
Copy link
Member

leofeyer commented Mar 5, 2020

I think the correct fix for that would be to install from source instead from dist:

    "config": {
        "preferred-install": {
            "contao/*": "source",
            "*": "dist"
        }
    },

@bytehead
Copy link
Member Author

bytehead commented Mar 5, 2020

Revert PR: #13

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants