This repository has been archived by the owner on Jun 2, 2021. It is now read-only.
Fix webmock dependency, update http.rb to v0.9.0 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use http 0.8 and that is incompatible with previous versions of webmock.
|
Seems like the tests are incompatible with the newer webmock, though ¯_(ツ)_/¯ |
|
Is there somehow a way of making this work? |
|
@pxlpnk that's the plan, I mainly created the PR to double-check that it is not an issue with my environment. |
|
👍 On 7/23/15, Boris Bügling notifications@github.com wrote:
Andreas Tiefenthaler |
|
Seems like bumping http fixed this ¯_:computer:_/¯ |
|
Such computers. We might want to bump the http version in the other gems too then. |
pxlpnk
changed the title
pxlpnk
added a commit
that referenced
this pull request
Jul 23, 2015
Fix webmock dependency, update http.rb to v0.9.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use http 0.8 and that is incompatible with previous versions of webmock.