This repository has been archived by the owner on Feb 16, 2021. It is now read-only.
Migrate to gatsby plugin image #91
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axe312ger
commented
Dec 22, 2020
src/pages/index.js
Outdated
| background: "rgb:000000" | ||
| ) { | ||
| placeholder: TRACED_SVG | ||
| # background: "rgb:000000" |
There was a problem hiding this comment.
note this API feature is currently unsupported. We need to reimplement it.
There was a problem hiding this comment.
I reimplemented it :)
axe312ger
commented
Jan 15, 2021
| "gatsby-transformer-remark": "^2.13.0", | ||
| "gatsby-transformer-sharp": "^2.9.0", | ||
| "gatsby-transformer-sharp": "2.11.0-next.1-dev-1610717931719", |
There was a problem hiding this comment.
I am aware of these "weird" version numbers. These will be replaced later on as soon gatsby-plugin-image is published with all features & fixes we need for Contentful support
axe312ger
commented
Jan 15, 2021
| @@ -10,6 +10,8 @@ const RootIndex = ({ data }) => { | |||
| const posts = data?.allContentfulBlogPost?.edges | |||
| const [author] = data?.allContentfulPerson?.edges | |||
|
|
|||
| console.log({ author, posts, data }) | |||
There was a problem hiding this comment.
note to myself: remove this debug logger
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #90, this is the first iteration of getting gatsby-source-contentful & this starter ready for the upcoming gatsby-plugin-image
This is WIP!