-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use set environment in commands #150
Conversation
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
==========================================
+ Coverage 82.34% 82.58% +0.23%
==========================================
Files 57 57
Lines 1144 1131 -13
==========================================
- Hits 942 934 -8
+ Misses 202 197 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First Round, this looks really great. I have some small comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow so many files changed 👏 looks good!
CI is just timing out on unit tests but looks like everything is passing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 This 👏 is 👏 amazing 👏
One last tiny comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
Fix for #68
Find and add
management-token
,space-id
,environment-id
andhost
to context.Description
Added middleware function (using yargs middlewares) to build the context by checking if the
management-token
,space-id
,environment-id
andhost
are set in the.contentfulrc.json
or passed into the command via flags.Motivation and Context
This fixes #68 and simplifies checking for cli settings.
Todos