feat: init typescript #1570
Merged
feat: init typescript #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcolink
approved these changes
Jul 29, 2022
| @@ -0,0 +1,104 @@ | |||
| { | |||
| "compilerOptions": { | |||
| /* Visit https://aka.ms/tsconfig to read more about this file */ | |||
There was a problem hiding this comment.
Should we remove all these comments?
There was a problem hiding this comment.
just kept them for now as a quick reference, will remove when we have test config inplace 👍🏼
|
🎉 This PR is included in version 2.0.0-beta.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
mshaaban0
added a commit
that referenced
this pull request
Aug 29, 2022
mshaaban0
added a commit
that referenced
this pull request
Sep 1, 2022
mshaaban0
added a commit
that referenced
this pull request
Feb 2, 2023
mshaaban0
added a commit
that referenced
this pull request
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Initialise typescript and allow commonjs and esm to co-exist
Description
This PR introduces typescript to the codebase, it'll allow us to work with esm, and commonjs
Next we will configure tests to be working with typescript as well.