Return all resources when some already cached

[o0-zzuf-0o]

The link resolver isn't fetching all resources when some are already present in the cache pool.

The cause of this is is in the LinkResolver fetchResourcesForGivenIds function:

• The resources fetched from the pool are put into a numerically indexed array.
• The resources fetched from the api (via fetchCollectionFromApi) are also a numerically indexed array.
• The arrays are combined using the + operator.

The + operator returns the right-hand array appended to the left-hand array; for keys that exist in both arrays, the elements from the left-hand array will be used, and the matching elements from the right-hand array will be ignored.

More Info

Combining the arrays using array_merge appears to produce the desired behaviour.

[o0-zzuf-0o]

The failing check appears to be unrelated:

1. src/SystemProperties/ContentType.php (single_trait_insert_per_statement, space_after_semicolon, braces)

[etiennenoel]

This needs to be merged! Any plans to merge this?