Prevent invalid links from rendering an entry inaccessible #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Sebb767 we are interested in this PR to be merged too. If you can find some time to review it, it would be really appreciated 😁 |
|
Any luck on this PR? Would help us out! |
|
Merging this PR as-is would change the behavior of the library significantly; therefore we can't easily merge it. We're currently working on a way to allow rendering entries with invalid links via a configuration flag in order to fix this issue. |
|
@Sebb767 Is that planned / already fixed in the main branch? thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a link associated to an entry cannot be resolved, the attempt to resolve the parent entity fails. This can even cause an attempt to fetch a collection of entries to fail.
This change assumes it is acceptable to produce a null value for an invalid link rather than throw an exception.