Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Compilation fix for a case when project path contains spaces #233

Conversation

anton-plebanovich
Copy link
Contributor

No description provided.

@loudmouth
Copy link
Contributor

Hi Anton,

Can you please provide some context as to what the goal of this PR is? What package manager are you using for instance? The swiftlint script for the SDK should not be executed if the SDK is a dependency on your project; were you seeing it being executed?

@anton-plebanovich
Copy link
Contributor Author

Hi @loudmouth got error when tried to add contentful.swift via a Carthage and my project path contained space.

@anton-plebanovich
Copy link
Contributor Author

@loudmouth If it recompiles from source build phase script is performed and build doesn't compile. I'm facing this issue right now while trying to build for Xcode 10.1. Could you possibly merge this one?

@loudmouth
Copy link
Contributor

Hey @anton-plebanovich i can merge if you rebase on master...currently there are merge conflicts that make merging not possible

@anton-plebanovich
Copy link
Contributor Author

Strange, I have no conflicts. Merged in master anyway so should be good now after CI finishes build.

@loudmouth loudmouth merged commit a9a39f1 into contentful:master Nov 7, 2018
@loudmouth
Copy link
Contributor

@anton-plebanovich I just released 4.1.1.

Since this was only an issue with Carthage, there is no cocoapods release for this version.

@anton-plebanovich
Copy link
Contributor Author

Great! Thanks!

@anton-plebanovich anton-plebanovich deleted the feature/supprot-spaces-in-project-path branch November 7, 2018 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants