Skip to content
This repository has been archived by the owner on Sep 11, 2018. It is now read-only.

[Changed] Prepare docs before publish #43

Merged
merged 1 commit into from
Jul 27, 2015
Merged

Conversation

sdepold
Copy link
Contributor

@sdepold sdepold commented Jul 27, 2015

No description provided.

neonichu added a commit that referenced this pull request Jul 27, 2015
[Changed] Prepare docs before publish
@neonichu neonichu merged commit 9e66028 into master Jul 27, 2015
@neonichu neonichu deleted the hotfix/deployment branch July 27, 2015 08:50
@johanneswuerbach
Copy link

I think a better fix would have been to add skip_cleanup: true to the deploy section.

@sdepold
Copy link
Contributor Author

sdepold commented Jul 27, 2015

that sounds good as well :D

@neonichu
Copy link
Contributor

IMO, I think it's better that the Makefile is setup so that it doesn't rely on external factors to function.

@johanneswuerbach
Copy link

Sure, but preparing the docs twice means you could end up in publishing something you didn't tested. Also travis is running a git stash before deploy without skip_cleanup: true, which can cause more side-effects then just this.

@neonichu
Copy link
Contributor

True, let's do both, because the generate rules are not executed again if the files are already up-to-date. Then publish can work on its own, but we still publish what we tested.

@neonichu
Copy link
Contributor

=> #44

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants