Makefile.include: add verbosity control (make V=1 for old behaviour) #305
Conversation
…our) This shortens $(CC) and $(AR) lines to a much more readable length, making warnings stick out clearly. The spaces after "CC" and "AR" are to reserve space for other operations that may use longer names, such as the communly found "BUILD" or "GENERATE".
|
Looks like a good idea! Do you have an example of what the shorter output looks like? I wasn't sure exactly what the Makefile lines would amount too. |
|
Here's an example of a run: http://pastebin.com/5SxQbukW I stole the idea from the Linux kernel, which has had this sort of verbosity control for years. Many other projects do, too. |
|
Love it. Very nice how the warnings stand out like that. A big 👍 from me. |
Makefile.include: add verbosity control (make V=1 for old behaviour)
|
This change breaks compatibility with cmd.exe :-(( We have quite some pull requests waiting months for review. I don't know why we then have others being merged without a chance for discussion within an hour ! I request to have this change reverted ! |
|
cmd.exe is Window's shell, correct ? Does it dislike the "&&" ? If yes, would it be happier with ";" instead ? (Which in this case is almost equivalent.) |
|
Ooops, my bad - being quite a bit too trigger-happy. Sorry about that, and thanks for spotting this! I created a reverse-pull request: #308 |
|
@wpwrak First of all thanks for your quick reaction. Yes, cmd.exe is the default shell for Windows. There's a port of GNU make to Win32 ("native", non-Cygwin) that has special precautions to work (as far as possible) with cmd.exe as shell for make recipes. So far the Contiki build is compatible with this setup. The functionality of cmd.exe isn't comparable at all to "usual" shells. There's no meaningfull concatenation of commands. AFAIK the usual way to control build output is to have several independent lines in the make recipe like: A somewhat popular way to control that is by introducing a variable $(AT) which is either empty or set to '@' and used like: |
Revert "Merge pull request #305 from frtos-wpan/pull-verbosity"
|
Okay, we can use that approach. For example libopencm3 calls the "AT" variable "Q". To avoid doubling the number of output lines, it also needs an opposing variable. It's a little more intrusive because each recipe affected has to be changed, instead of simply redefining CC et al. I'll give it a try and post a new pull request. |
Maybe I don't understand you correctly but one might replace the whole "@echo ..." thingy with a line consistly only of a variable like
Yeah, that's more or less the reason why it wasn't done before. But the "quick way" unfortunately doesn't get us there...
:-) |
|
I think I found a solution that should please all involved. Does this look good ? Architectures that override rules also need to be adapted. Here's an example for stm32-ocm3 (which is out of tree): Architectures whose overriding rules aren't adapted will behave as they did before verbosity control. The output is almost the same as with my first try: The main difference is that I used the added flexibility to turn "CC foo.co" into the more useful "LD foo-nosyms.stm32-e407". If this looks good, I'll send a pull request. Not sure if I should try to adapt the various architectures as well, or leave that to people who use them and can actually test what they're doing. |
|
Hm, I'm wondering if there's am misunderstanding here or if we have just different opinions. I already mentioned above that I'd prefer variables containing the whole echo command(s) - especially because of the distributed nature of the Makefiles. Instead of explaining how the echo is supposed to be formatted you can simply supply the correctly formatted echo commands as variables. And as a side effect you can set the variables only in the V=0 scenario so there's no need for $(VS): TRACE_CC = echo " CC " $< In case you don't know: If a command line in a recipe is empty then GNU make just completely skips the line, so in the V=1 scenario both foo.o: foo.c |
|
Okay, that's tidier. I like it, thanks ! New versions: and The empty initializations of TRACE_* on V=1 are there to prevent environment variables from sneaking in. |
:-)
You're welcome ! If you send a pull request with this I'll merge it. Please send then a message to the list about the change as it heavily modifies the default behavior. And "invite" the Makefile maintainers to make use of it in their custom recipes. |
Makefile.include: add verbosity control (make V=1 for old behaviour)
Revert "Merge pull request contiki-os#305 from frtos-wpan/pull-verbosity"
The Contiki build is rather chatty, which makes it very difficult to spot compiler warnings. This adds short$(CC) and $ (AR) invocations that don't show the entire command. The old behaviour can be obtained by running make with V=1.
I suggested this on the mailing list a few weeks ago but didn't get a response.