New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ContikiMAC framer fix #816
Conversation
👍 This framer is not set anywhere in the source tree, and it is probably not clear to many users when it is needed. Perhaps it should be made the default for those platforms and examples that use Rime over ContikiMAC, since it is often the case that Rime packets are too short for ContikiMAC's strobing mechanism to catch them reliably. |
You're right. I've added a note to the wiki page https://github.com/contiki-os/contiki/wiki/Contikimac. Also, I'm now defaulting to this framer when using rime over ContikiMAC. The |
Looks good, but you should probably retain the copyright year of the original ContikiMAC source code in the ContikiMAC framer. |
Done |
@@ -512,6 +512,10 @@ typedef uint32_t rtimer_clock_t; | |||
#define QUEUEBUF_CONF_NUM 8 | |||
#endif | |||
|
|||
#ifndef NETSTACK_CONF_FRAMER | |||
#define NETSTACK_CONF_FRAMER contikimac_framer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This setting belongs in the section named "Network Stack Configuration", where the Rime driver is set.
Now the positions of the framer definitions are being preserved. |
The
contikimac_framer
lacks alength
function, which is why it does not currently work.