New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDNSS support, again #999
RDNSS support, again #999
Conversation
Adds a common in contiki nameserver pool for handling name resolution servers. This will allow in following commit to use RDNSS messages within RA.
Sends DNS information within RA messages (if enabled)
On the same commit the src have been uncrustified and some typo fixes as well as includes missing.
… servers, but only a single server variable. This saves space.
Hi, I see two perspectives here:
Regards, |
I was the one who wanted to have the |
Hi Adam, Nice that you explicitly state it this way :-) Sometimes the GH threads feel a bit like it would be just for my personal benefit to keep memory consumption down... Regards, |
This morning we had a build fail with an overflow of 3 bytes of RAM - on a modern state-of-the-art wireless system-on-a-chip. So keeping the memory consumption low still is pretty useful. |
Hey! Cool for the memory fixtures for smallest platforms. I also think is a good idea to keep memory footprint to a minimum. However, sometimes there's significant trade-off between code complexity (#if #else everywhere) and memory footprint. In any case, look good to me 👍 |
👍 |
This is an update of #643, which introduces a nice new API for the DNS resolver library and adds support for RDNSS. Unfortunately the original pull request failed on some platforms as the code was not optimized for the case when there was only one DNS server configured.
This updated pull request adds a special-case optimization for when we only have one DNS server which makes the code smaller in that situation.
Ping @lebrush and @oliverschmidt.