Skip to content

Commit

Permalink
Merge branch 'add_systests'
Browse files Browse the repository at this point in the history
  • Loading branch information
Vipin Jain committed Mar 10, 2015
2 parents 2380280 + 1aa75c2 commit 86d8913
Show file tree
Hide file tree
Showing 9 changed files with 711 additions and 133 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ unit-test: build

system-test: build
go test -v github.com/contiv/netplugin/systemtests/singlehost
go test -v github.com/contiv/netplugin/systemtests/twohosts
go test --timeout 20m -v github.com/contiv/netplugin/systemtests/twohosts
2 changes: 1 addition & 1 deletion netd.go
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ func main() {
defHostLabel,
"label used to identify endpoints homed for this host, default is host name")
flagSet.BoolVar(&opts.publishVtep,
"do-not-publish-vtep",
"publish-vtep",
true,
"publish the vtep when allowed by global policy")

Expand Down
8 changes: 4 additions & 4 deletions netdcli/cfg.go
Original file line number Diff line number Diff line change
Expand Up @@ -152,9 +152,9 @@ func processAdditions(stateDriver core.StateDriver, allCfg *netmaster.Config) (e

func processDeletions(stateDriver core.StateDriver, allCfg *netmaster.Config) (err error) {
for _, tenant := range allCfg.Tenants {
err = netmaster.DeleteTenant(stateDriver, &tenant)
err = netmaster.DeleteEndpoints(stateDriver, &tenant)
if err != nil {
log.Printf("error deleting tenant '%s' \n", err)
log.Printf("error deleting endpoints '%s' \n", err)
continue
}

Expand All @@ -164,9 +164,9 @@ func processDeletions(stateDriver core.StateDriver, allCfg *netmaster.Config) (e
continue
}

err = netmaster.DeleteEndpoints(stateDriver, &tenant)
err = netmaster.DeleteTenant(stateDriver, &tenant)
if err != nil {
log.Printf("error deleting endpoints '%s' \n", err)
log.Printf("error deleting tenant '%s' \n", err)
continue
}
}
Expand Down
9 changes: 8 additions & 1 deletion netmaster/netmaster.go
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,11 @@ func DeleteTenant(stateDriver core.StateDriver, tenant *ConfigTenant) error {
return err
}

return DeleteTenantId(stateDriver, tenant.Name)
if len(tenant.Networks) == 0 {
return DeleteTenantId(stateDriver, tenant.Name)
}

return nil
}

func validateNetworkConfig(tenant *ConfigTenant) error {
Expand Down Expand Up @@ -455,6 +459,9 @@ func DeleteNetworks(stateDriver core.StateDriver, tenant *ConfigTenant) error {
}

for _, network := range tenant.Networks {
if len(network.Endpoints) > 0 {
continue
}
nwMasterCfg := &MasterNwConfig{StateDriver: stateDriver}
err = nwMasterCfg.Read(network.Name)
if err != nil {
Expand Down
10 changes: 8 additions & 2 deletions netutils/netutils.go
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,7 @@ func ParseTagRanges(ranges string, tagType string) ([]TagRange, error) {

func GetLocalIp() (string, error) {
var addrs []netlink.Addr
localIpAddr := ""

for idx := 0; idx < 3; idx++ {
linkName := "eth" + strconv.Itoa(idx)
Expand All @@ -228,11 +229,16 @@ func GetLocalIp() (string, error) {
return "", err
}
if len(addrs) > 0 {
return addrs[0].IP.String(), nil
localIpAddr = addrs[0].IP.String()
}
}

return "", errors.New("local ip not found")
err := errors.New("local ip not found")
if localIpAddr != "" {
err = nil
}

return localIpAddr, err
}

func ParseCIDR(cidrStr string) (string, uint, error) {
Expand Down
Loading

0 comments on commit 86d8913

Please sign in to comment.