Add extra validation check for v2plugin #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, demo-v2plugin doesn't check if contiv is installed and enabled. This patchset is to check if v2plugin is installed and enabled at the end of the installation Signed-off-by: <kalei@cisco.com>
chrisplo
reviewed
Dec 5, 2017
scripts/python/startSwarm.py
Outdated
| @@ -45,6 +45,21 @@ | |||
| node.runCmdThread(command) | |||
|
|
|||
| time.sleep(15) | |||
|
|
|||
| print "Check netplugin is installed and enabled" | |||
| out, x, y = nodes[0].runCmd("docker plugin ls") | |||
There was a problem hiding this comment.
if you don't care about the err and exit value, use '_', though I think you could have docker installed but docker plugin ls fail when dockerd is not running, so you might want to check exit status
chrisplo
approved these changes
Dec 5, 2017
dseevr
approved these changes
Dec 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, demo-v2plugin doesn't check if contiv is installed and
enabled.
This patchset is to check if v2plugin is installed and enabled at the
end of the installation
Signed-off-by: kalei@cisco.com