Fixed a bug on checks file. #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added .idea directory to list of ignored files Fixed a bug that occured if go-version had a PATCH version number Signed-off-by: André Martins <martins@noironetworks.com>
| @@ -6,6 +6,7 @@ | |||
| # Folders | |||
| _obj | |||
| _test | |||
| .idea/ | |||
There was a problem hiding this comment.
just for my understanding, how is this directory used? Is it IDE specific?
There was a problem hiding this comment.
Yes, it is the IntelliJ IDEA
|
closing this PR for now, as right now there is a strict dependency between go version on host and vagrant-vm. However, this dependency does impose an unnecessarily strict restriction on the development environment. I will open a separate PR to make changes to the test-environment instead which can remove this dependency while not affecting the test times. Hope that is ok. |
dseevr
pushed a commit
to dseevr-dev/netplugin
that referenced
this pull request
Oct 24, 2017
* Hostname added * Hostname is set in RegisterService
dseevr
pushed a commit
to dseevr-dev/netplugin
that referenced
this pull request
Nov 28, 2017
* infranw: fixed model backward compatibility * fix typo error * Updated comments - default value for nwType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added .idea directory to list of ignored files
Fixed a bug that occured if go-version had a PATCH version number
Signed-off-by: André Martins martins@noironetworks.com