Use docker containers as hosts for testing netplugin #37
Conversation
| 4. Add $GOPATH/dockerhost to PATH | ||
| 5. Set CONTIV_NODES to required number of nodes | ||
| 6. Run start-dockerhosts | ||
|
|
There was a problem hiding this comment.
Need to specify, either here or in prerequisites, that nsenter must be installed for this to work.
There was a problem hiding this comment.
Another pre-requisite is having docker installed on host as well.
| @@ -14,7 +14,7 @@ echo "Checking gofmt..." | |||
| fmtRes=$(gofmt -l ./) | |||
| if [ -n "${fmtRes}" ]; then | |||
| echo -e "gofmt checking failed:\n${fmtRes}" | |||
| exit 1 | |||
| # exit 1 | |||
There was a problem hiding this comment.
Why exit with '0' code when go-fmt fails? Any reason for this change?
There was a problem hiding this comment.
Sorry that got in by mistake. Reverted.
Btw if i do a make build two times without clean i get gofmt errors.
|
i have pushed the changes handling all the comments . Pls take a relook . |
| @@ -112,6 +112,9 @@ In the examples directory [two_hosts_multiple_tenants.json](examples/two_hosts_m | |||
| [two_hosts_multiple_tenants_mix_vlan_vxlan.json](examples/two_hosts_multiple_tenants_mix_vlan_vxlan.json) shows the creation of a multi-tenant | |||
| (disjoint, overlapping) networks within a cluster. | |||
|
|
|||
| ####Trying the multi-host tests on a single machine using docker as hosts | |||
| If you cannot launch VM on your host one can also test the multi-host network by simulating hosts using docker containers. Please see [docs/Dockerhost.md](docs/Dockerhost.md) for instructions. | |||
There was a problem hiding this comment.
@sachja overall LGTM
Suggest replacing If you cannot... with If you cannot launch a VM on your host, especially when the host is a VM itself, you can also...
| ------------- | ||
| The following needs to be installed on the host machine | ||
| 1. Docker | ||
| 2. nsenter |
There was a problem hiding this comment.
Leave a pointer to nsenter repo so someone can get going)
|
@sachja - LGTM |
Use docker containers as hosts for testing netplugin
No description provided.