WIP system tests improvements #933
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclejack
force-pushed
the
system_tests_improvements
branch
3 times, most recently
from
d59a29c
to
e7d4d80
Compare
unclejack
force-pushed
the
system_tests_improvements
branch
from
e7d4d80
to
64e18e4
Compare
|
build pr |
gkvijay
reviewed
Oct 13, 2017
Makefile
Outdated
| @@ -27,6 +27,7 @@ GOVET_CMD := go tool vet | |||
| CI_HOST_TARGETS ?= "host-unit-test host-integ-test host-build-docker-image" | |||
| SYSTEM_TESTS_TO_RUN ?= "00SSH|Basic|Network|Policy|TestTrigger|ACIM|Netprofile" | |||
| ACI_GW_IMAGE ?= "contiv/aci-gw:04-12-2017.2.2_1n" | |||
| L3_SYSTEM_TESTS_TO_RUN ?= "00SSH|Basic|Bgp|Network|Policy|TestTrigger|ACIM|Netprofile" | |||
There was a problem hiding this comment.
@unclejack, I think we should not filter the L3 tests. Instead we should run all the tests. Last time L3 tests failed because there was a change made that affected the docker service feature. L2 system tests in CI did not catch it as there were filters. Please run all the tests in L3 mode and that can be run once a day (not necessarily for commits)
There was a problem hiding this comment.
@gkvijay: Thank you for taking a look at this. I'll make sure to check if the tests pass now without filters.
Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com>
Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com>
unclejack
force-pushed
the
system_tests_improvements
branch
from
64e18e4
to
298ffff
Compare
|
@gkvijay: The BgpTriggerLinkUpDown test is failing now. Do you happen to know something about that? We've got to sort out that issue before we can enable all the tests for the L3 test run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will make some improvements to the system tests.
This PR includes the following changes right now:
There's no need to have such a long sleep for a Vagrant based setup. The VMs created by Vagrant aren't emulated, they're virtual machines which use hardware acceleration.
Once these changes pass and the L3 tests are fine, I'll make more changes.