Skip to content

Commit

Permalink
Composer: update dependecies and description
Browse files Browse the repository at this point in the history
  • Loading branch information
@f3l1x
f3l1x committed Jan 11, 2017
1 parent a383615 commit 84d2678
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions composer.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "contributte/console",
"description": "Best console to nette framework",
"description": "Best console to Nette Framework",
"keywords": ["nette", "symfony", "console"],
"type": "library",
"license": ["MIT"],
Expand All @@ -13,13 +13,13 @@
],
"require": {
"php": ">= 5.6",
"symfony/console": "^3.2.0"
"symfony/console": "^3.2.1"

This comment has been minimized.

Sign in to view

Copy link
@TomasVotruba

TomasVotruba Mar 16, 2017

What was the bug in 3.2.0?
},
"require-dev": {
"ninjify/qa": "^0.3.1",
"ninjify/nunjuck": "^0.1.1",
"nette/di": "^2.4.4",
"nette/http": "^2.4.2"
"ninjify/qa": "^0.3.3",
"ninjify/nunjuck": "^0.1.4",
"nette/di": "^2.4.5",
"nette/http": "^2.4.3"
},
"suggest": {
"nette/di": "to use ConsoleExtension[CompilerExtension]"
Expand Down

8 comments on commit 84d2678

@TomasVotruba
Copy link

@TomasVotruba TomasVotruba commented on 84d2678 Mar 16, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job 👍 . I was looking for normal Symfony\Console integration twice this week.

People are still using the Router one. I'll recommend this everywhere.

I see you have separated Nette\DI compiler extension. Do you plan to add Symfony DI adapter as well?

@enumag
Copy link
Contributor

@enumag enumag commented on 84d2678 Mar 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan to add Symfony DI adapter as well?

What do you mean by this?

@f3l1x
Copy link
Member Author

@f3l1x f3l1x commented on 84d2678 Mar 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enumag @TomasVotruba Thank you, I appreciate it.

Do you plan to add Symfony DI adapter as well?

I don't known neither.

@TomasVotruba
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Symfony Bundle to allow loading Command the same way they are in Nette:

services:
    - MyCommand

@f3l1x
Copy link
Member Author

@f3l1x f3l1x commented on 84d2678 Mar 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomasVotruba I get your point now, but this repo is mainly for Nette. We'll see in the future.

@TomasVotruba
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@f3l1x Ok, thanks for into.
I might create a package to support Nette, Symfony and Laravel for now. I'm often switching framework and need 1 tool to use.

@enumag
Copy link
Contributor

@enumag enumag commented on 84d2678 Mar 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomasVotruba You know that should NOT be one package, right?

@TomasVotruba
Copy link

@TomasVotruba TomasVotruba commented on 84d2678 Mar 17, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enumag I know that's common idea. We can talk about it in person if you want.

Please sign in to comment.