Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ConsoleExtension.php #76

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Update ConsoleExtension.php #76

merged 2 commits into from
Jan 4, 2024

Conversation

janzarubadek
Copy link
Contributor

Lazy loading using the service tag does not work.

Lazy loading using the service tag does not work.
@f3l1x
Copy link
Member

f3l1x commented Jan 4, 2024

Hey ✋ @janzarubadek. Is the tag really needed? Describe me please your use-case.

@janzarubadek
Copy link
Contributor Author

Hey ✋ @janzarubadek. Is the tag really needed? Describe me please your use-case.

Hi, I replaced kdyby/console with this contributte/console. Without this feature, there is no point for us to use this package and it will be removed from our products. Cases of use can be seen in the old kdyby products. Thanks.

@f3l1x
Copy link
Member

f3l1x commented Jan 4, 2024

I don't get it. Why do you need use tag for lazy-loading? All commands are lazy-loaded by default by it's type. What's the case you need tag?

Copy link

codecov bot commented Jan 4, 2024

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

fixing "use Nette\Utils\Arrays"
@janzarubadek
Copy link
Contributor Author

I don't get it. Why do you need use tag for lazy-loading? All commands are lazy-loaded by default by it's type. What's the case you need tag?
Kdyby DI extensions insert commands dynamically:
$builder->addDefinition(....)->addTag(....
Sorry. I don't have the space for a complete rebuild. Many important people here consider nette a dying project etc...

Besides, it is written in your documentation that it is supported.

@f3l1x
Copy link
Member

f3l1x commented Jan 4, 2024

I will add this tag support back, just for you.

PS: Do you have Slack or something? I would like to hear about your project more and also discuss it how do use it with Kdyby, because Kdyby does not support nette v4 or does?

@f3l1x f3l1x merged commit 07ec27b into contributte:master Jan 4, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants