Přidání inline metody platby. #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Attanon Ahoj, libi se mi to. Diky za PR. Akorat si rikam, ze je to docela velky BC break. Co to pridat jako 4 volitelny parametr nebo jako class property? Co ty na to? |
Attanon
force-pushed
the
master
branch
3 times, most recently
from
9481f79
to
0d203fb
Compare
|
Mozna bych zkusil uplne novou metody payInline(). Co ty na to? |
|
@f3l1x Předělal jsem to na metodu. Takhle to vyhovuje? |
|
@Attanon Vypada to dobre. Akorat je potreba upravit README. |
| @@ -382,13 +381,73 @@ public function pay(Payment $payment, $channel, $callback) | |||
| throw new GopayException($e->getMessage(), 0, $e); | |||
| } | |||
|
|
|||
| Nette\Utils\Callback::invokeArgs($callback, array($paymentSessionId)); | |||
There was a problem hiding this comment.
Tohle by melo jit az tesne pred presmerovani.
Attanon
force-pushed
the
master
branch
4 times, most recently
from
debe666
to
129bbb6
Compare
|
Co takhle? |
| @@ -24,7 +24,7 @@ | |||
| ], | |||
| "require": { | |||
| "php": ">=5.3.2", | |||
| "markette/gopay-api": "~2.5.0", | |||
| ``` | ||
|
|
||
| #### Chyby s platbou | ||
| V okamžiku zavolání `pay()` nebo `payInline()` se mohou pokazit dvě věci: |
|
@Attanon lepsi, mas tam par komentaru. Diky. |
|
@f3l1x ... asi 25 mailů s notifikací... |
|
Snad jsem projel všechny komentáře:) |
|
Merged via b1f85ff. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ahoj,
provedl jsem malou úpravu metody pay u service, aby bylo možné získat potřebné informace k vytvoření nové inline platební brány. Je to malinká změna.