-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Přidání inline metody platby. #45
Conversation
@Attanon Ahoj, libi se mi to. Diky za PR. Akorat si rikam, ze je to docela velky BC break. Co to pridat jako 4 volitelny parametr nebo jako class property? Co ty na to? |
9481f79
to
0d203fb
Compare
Mozna bych zkusil uplne novou metody payInline(). Co ty na to? |
@f3l1x Předělal jsem to na metodu. Takhle to vyhovuje? |
@Attanon Vypada to dobre. Akorat je potreba upravit README. |
@@ -382,13 +381,73 @@ public function pay(Payment $payment, $channel, $callback) | |||
throw new GopayException($e->getMessage(), 0, $e); | |||
} | |||
|
|||
Nette\Utils\Callback::invokeArgs($callback, array($paymentSessionId)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tohle by melo jit az tesne pred presmerovani.
debe666
to
129bbb6
Compare
Co takhle? |
@@ -24,7 +24,7 @@ | |||
], | |||
"require": { | |||
"php": ">=5.3.2", | |||
"markette/gopay-api": "~2.5.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Muzes pouzit 2.5.1
``` | ||
|
||
#### Chyby s platbou | ||
V okamžiku zavolání `pay()` nebo `payInline()` se mohou pokazit dvě věci: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Radek
@Attanon lepsi, mas tam par komentaru. Diky. |
@f3l1x ... asi 25 mailů s notifikací... |
Snad jsem projel všechny komentáře:) |
Merged via b1f85ff. Thank you. |
Ahoj,
provedl jsem malou úpravu metody pay u service, aby bylo možné získat potřebné informace k vytvoření nové inline platební brány. Je to malinká změna.