Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented failure transports + retry mechanism #2

Merged
merged 10 commits into from
Jul 31, 2023
Merged

Implemented failure transports + retry mechanism #2

merged 10 commits into from
Jul 31, 2023

Conversation

JanMikes
Copy link
Contributor

@JanMikes JanMikes commented Jul 18, 2023 •
edited
Loading

Implemented missing features:

  • Console commands (remove/retry/show failed messages)
  • Retry strategy
  • Default retry strategy
  • Custom retry strategy
  • Specify failure transport globally
  • Specify failure transport per transport
  • PCNTL listeners

@JanMikes JanMikes changed the title Draft: Register symfony event listeners (retry, failure, sigterm) Draft: Register symfony event listeners (retry, failure, signals) Jul 18, 2023
@coveralls
Copy link

coveralls commented Jul 18, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5588838497

  • 46 of 49 (93.88%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 92.693%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/DI/Pass/EventPass.php 34 35 97.14%
src/DI/Utils/BuilderMan.php 12 14 85.71%
Totals Coverage Status
Change from base Build 5561936149: 0.08%
Covered Lines: 444
Relevant Lines: 479
💛 - Coveralls

@JanMikes JanMikes changed the title Draft: Register symfony event listeners (retry, failure, signals) Implemented failure transports + retry mechanism Jul 19, 2023
@JanMikes
Copy link
Contributor Author

Ready for review @f3l1x

We will test on production tomorrow.

@JanMikes
Copy link
Contributor Author

So far works well without any issues.

@f3l1x f3l1x merged commit 09b12cc into contributte:master Jul 31, 2023
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JanMikes @coveralls @f3l1x