Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Nette 3 #17

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Upgrade to Nette 3 #17

merged 1 commit into from
Oct 31, 2019

Conversation

RiKap
Copy link
Contributor

@RiKap RiKap commented Oct 29, 2019

Hi @foxycode
I made upgrade to Nette 3.
Test it on localhost and it looks fine to me.

Let me know if it is ok for you.
If yes, please merge it and release a new version.
Thank you.

@foxycode
Copy link
Member

@RiKap Looks good, thanks for your work.

  • It is backward incompatible with 2.4?
  • This package requires vrtak-cz/newrelic-tracy, can you please update it too?

@RiKap
Copy link
Contributor Author

RiKap commented Oct 30, 2019 •
edited

@foxycode

  • It is not compatible with 2.4.
  • I tested it locally, and it works with vrtak-cz/newrelic-tracy in version 8.0. I think that main issue is that I don't know how to setup TravisCI, because ~2.4 should install Tracy 2.7, which support Nette 3.

@foxycode foxycode merged commit 03ace2d into contributte:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RiKap @foxycode