Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The index of Unknown used in //ModelStructure/Outputs is wrong #1

Closed
lausdahl opened this issue Jun 4, 2015 · 2 comments
Closed

The index of Unknown used in //ModelStructure/Outputs is wrong #1

lausdahl opened this issue Jun 4, 2015 · 2 comments
Assignees
@MaartenMJR
Labels
bug

Comments

@lausdahl
Copy link
Contributor

lausdahl commented Jun 4, 2015

The index used in the index attribute in Unknown in outputs under model structure is wrong:

<?xml version="1.0" encoding="ISO-8859-1"?>
<fmiModelDescription fmiVersion="2.0" modelName="tank2" guid="{67d835d6-8a93-41f6-bd55-ed668d3c5b52}" generationTool="20-sim" numberOfEventIndicators="0" copyright="Controllab Products B.V." license="-">
<CoSimulation modelIdentifier="tank2" needsExecutionTool="false" canHandleVariableCommunicationStepSize="false" canInterpolateInputs="true" maxOutputDerivativeOrder="0" canRunAsynchronuously="false" canBeInstantiatedOnlyOncePerProcess="true" canNotUseMemoryManagementFunctions="true" canGetAndSetFMUstate="false" canSerializeFMUstate="false" providesDirectionalDerivative="false" />
<DefaultExperiment startTime="0.0" stopTime="16.0" />
<ModelVariables>
<ScalarVariable name="Drain1.p.p" valueReference="8" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="Drain1.r" valueReference="1" variability="fixed" causality="parameter">
<Real start="1.0" />
</ScalarVariable>
<ScalarVariable name="Drain1.puddle" valueReference="9" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="tank2.Node1.p1.p" valueReference="10" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="tank2.Node1.p2.p" valueReference="10" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="tank2.Node1.p3.p" valueReference="10" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="tank2.Node1.p1.phi" valueReference="14" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="tank2.Node1.p2.phi" valueReference="24" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="tank2.Node1.p3.phi" valueReference="12" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="tank2.Tank.p.e" valueReference="10" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="tank2.Tank.level" valueReference="11" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="tank2.Tank.area" valueReference="2" variability="fixed" causality="parameter">
<Real start="1.0" />
</ScalarVariable>
<ScalarVariable name="tank2.Tank.gravity" valueReference="3" variability="fixed" causality="parameter">
<Real start="9.81" />
</ScalarVariable>
<ScalarVariable name="tank2.Tank.liquid_density" valueReference="4" variability="fixed" causality="parameter">
<Real start="1.0" />
</ScalarVariable>
<ScalarVariable name="tank2.p1.p" valueReference="10" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="tank2.p1.phi" valueReference="14" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="tank2.p.p" valueReference="10" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="tank2.p.phi" valueReference="12" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="tank2.level" valueReference="11" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="valve2.FlowOut.p.e" valueReference="8" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="valve2.FlowOut.p.f" valueReference="23" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="valve2.FlowOut.flow" valueReference="23" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="valve2.FlowOut.effort" valueReference="8" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="valve2.R.p.e" valueReference="15" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="valve2.R.p.f" valueReference="23" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="valve2.R.FlowOut" valueReference="23" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="valve2.R.r" valueReference="5" variability="fixed" causality="parameter">
<Real start="7.0" />
</ScalarVariable>
<ScalarVariable name="valve2.R.waterFlow" valueReference="13" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="valve2.Valve.valvecontrol" valueReference="16" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="valve2.Valve.powerIn.p" valueReference="10" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="valve2.Valve.powerIn.phi" valueReference="14" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="valve2.Valve.powerOut.p" valueReference="15" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="valve2.Valve.powerOut.phi" valueReference="23" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="valve2.waterOut.e" valueReference="8" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="valve2.waterOut.f" valueReference="23" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="valve2.valveControl" valueReference="16" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="valve2.waterIn.p" valueReference="10" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="valve2.waterIn.phi" valueReference="14" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="p.p" valueReference="17" variability="continuous" causality="output">
<Real />
</ScalarVariable>
<ScalarVariable name="p.phi" valueReference="18" variability="continuous" causality="input">
<Real start="0.0" />
</ScalarVariable>
<ScalarVariable name="level" valueReference="19" variability="continuous" causality="output">
<Real />
</ScalarVariable>
<ScalarVariable name="valveControl" valueReference="20" variability="discrete" causality="input">
<Boolean start="0" />
</ScalarVariable>
<ScalarVariable name="Drain1.p.phi" valueReference="23" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="Drain1.p.phi_int" valueReference="21" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="Drain1.p.phi_int_initial" valueReference="6" variability="fixed" causality="parameter">
<Real start="0.0" />
</ScalarVariable>
<ScalarVariable name="tank2.Tank.p.f" valueReference="24" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="tank2.Tank.volume" valueReference="22" variability="continuous" causality="local">
<Real />
</ScalarVariable>
<ScalarVariable name="tank2.Tank.volume_initial" valueReference="7" variability="fixed" causality="parameter">
<Real start="0.0" />
</ScalarVariable>
</ModelVariables>
<ModelStructure>
<Outputs>
<Unknown index="17" />
<Unknown index="19" />
</Outputs>
</ModelStructure>
</fmiModelDescription>

it should have been

    <ModelStructure>
        <Outputs>
            <Unknown index="39" />
            <Unknown index="41" />
        </Outputs>
    </ModelStructure>

Note that index is the index of the scalarvariable = the number in the list of declared
MaartenMJR added a commit that referenced this issue Jun 8, 2015
@MaartenMJR
Outputs section: Added 1-based index to the corresponding model varia…
7a908a2 
…ble in stead of the value reference

ref: #1
@MaartenMJR MaartenMJR added the bug label Jun 8, 2015
@MaartenMJR MaartenMJR self-assigned this Jun 8, 2015
@MaartenMJR
Copy link
Contributor

Hi Kenneth,

Thank you for reporting this bug. I've fixed this in the following commit: 7a908a2

@margro
Copy link
Member

margro commented Jun 11, 2015

Should be fixed now with 5c0af36

@margro margro closed this as completed Jun 11, 2015
@richardpaynea55 richardpaynea55 mentioned this issue Apr 3, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaartenMJR MaartenMJR

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@margro @MaartenMJR @lausdahl