-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default values for cluster settings #52
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
kvaps
added a commit
to aenix-io/cozystack
that referenced
this pull request
Jun 24, 2024
This PR upgrades to Flux-Operator 0.6 released this morning, also includes: * #170 which is an aggregate PR, so #171 #172 etc. I think this PR now basically subsumes #170 and can replace it. I have at least 80% confidence there are no errors in this PR. It also restores the networkPolicy default and the deleted cozy-dashboard network policy, which we will see fixed (restored to install NetworkPolicy resources by default) in the next `flux-operator` release. Ref: controlplaneio-fluxcd/flux-operator#52
souleb
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
kvaps
pushed a commit
to aenix-io/cozystack
that referenced
this pull request
Jun 24, 2024
This PR upgrades to Flux-Operator 0.6 released this morning, also includes: * #170 which is an aggregate PR, so #171 #172 etc. I think this PR now basically subsumes #170 and can replace it. I have at least 80% confidence there are no errors in this PR. It also restores the networkPolicy default and the deleted cozy-dashboard network policy, which we will see fixed (restored to install NetworkPolicy resources by default) in the next `flux-operator` release. Ref: controlplaneio-fluxcd/flux-operator#52
kvaps
pushed a commit
to aenix-io/cozystack
that referenced
this pull request
Jun 24, 2024
This PR upgrades to Flux-Operator 0.6 released this morning, also includes: * #170 which is an aggregate PR, so #171 #172 etc. I think this PR now basically subsumes #170 and can replace it. I have at least 80% confidence there are no errors in this PR. It also restores the networkPolicy default and the deleted cozy-dashboard network policy, which we will see fixed (restored to install NetworkPolicy resources by default) in the next `flux-operator` release. Ref: controlplaneio-fluxcd/flux-operator#52 Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
kvaps
pushed a commit
to aenix-io/cozystack
that referenced
this pull request
Jun 24, 2024
This PR upgrades to Flux-Operator 0.6 released this morning, also includes: * #170 which is an aggregate PR, so #171 #172 etc. I think this PR now basically subsumes #170 and can replace it. I have at least 80% confidence there are no errors in this PR. It also restores the networkPolicy default and the deleted cozy-dashboard network policy, which we will see fixed (restored to install NetworkPolicy resources by default) in the next `flux-operator` release. Ref: controlplaneio-fluxcd/flux-operator#52 Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
kvaps
pushed a commit
to aenix-io/cozystack
that referenced
this pull request
Jun 24, 2024
This PR upgrades to Flux-Operator 0.6 released this morning, also includes: * #170 which is an aggregate PR, so #171 #172 etc. I think this PR now basically subsumes #170 and can replace it. I have at least 80% confidence there are no errors in this PR. It also restores the networkPolicy default and the deleted cozy-dashboard network policy, which we will see fixed (restored to install NetworkPolicy resources by default) in the next `flux-operator` release. Ref: controlplaneio-fluxcd/flux-operator#52 Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
kingdonb
added a commit
to kingdonb/cozystack
that referenced
this pull request
Jul 4, 2024
It is no longer necessary to set cluster.networkPolicy to ensure the default value is used, fixed in controlplaneio-fluxcd/flux-operator#52 Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #51