Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convco check --from-stdin should not need a .git repository #130

Closed
jbergstroem opened this issue May 16, 2023 · 2 comments
Closed

convco check --from-stdin should not need a .git repository #130

jbergstroem opened this issue May 16, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@jbergstroem
Copy link
Contributor

When invoking check by passing a commit from stdin I don't think a .git repository should be required. Not sure if a bug or intended feature.

$ echo "whatever: Test" | convco check --from-stdin
Error: could not find repository from '.'; class=Repository (6); code=NotFound (-3)

Refs: #53.

@jbergstroem
Copy link
Contributor Author

jbergstroem commented Jul 25, 2023

Thanks for working on this! I just tried compiling the latest head (60279b8) and the git warning still seems to be around (but the check still works!):

$ git status
fatal: not a git repository (or any of the parent directories): .git
$ echo 'foo: bar' | convco/target/debug/convco check --from-stdin
could not find repository from '.'; class=Repository (6); code=NotFound (-3)
FAIL  -  wrong type: foo  foo: bar

@hdevalke
Copy link
Collaborator

Yes, the error is still printed out for information. However, the commit will be checked and the command will exit with a non zero status in case the stdin message is invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants