-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check should fail on unrecognized types #53
Comments
Validate the commit type against the ones defined in config. Refs: #53
Validate the commit type against the ones defined in config. Refs: #53
For this repo, this is the output:
|
Are you saying it’s working/supposed to work like that already? |
No, that is the output of #55. Before merging it I would like to know if that's what you expected and if the error message is fine. |
Assuming the exit code is non-0, yes, that seems reasonable. |
Validate the commit type against the ones defined in config. Refs: #53
Thank you! :) |
Is this still the case? Shouldn't (Because it doesn't) |
The code is indeed only parsing the message, but not checking the types when read from stdin. |
I assumed this would work without a git repository as well: $ echo "whatever: Test" | convco check --from-stdin
Error: could not find repository from '.'; class=Repository (6); code=NotFound (-3) Gonna split this out into a new issue. |
convco check parses the commit information in
CommitParser
, which verifies the correct message format.However, the parsed type is never verified to be one of the configured types in Config.
The text was updated successfully, but these errors were encountered: