Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@commitlint/config-lerna-scopes warning with lerna^6.0.0 #3409

Closed
1 of 5 tasks
ChoSeoHwan opened this issue Oct 22, 2022 · 5 comments
Closed
1 of 5 tasks

@commitlint/config-lerna-scopes warning with lerna^6.0.0 #3409

ChoSeoHwan opened this issue Oct 22, 2022 · 5 comments

Comments

@ChoSeoHwan
Copy link

Expected Behavior

No warning when use @commitlint/config-lerna-scopes with lerna@^6.0.0

Current Behavior

Occurred warning when use @commitlint/config-lerna-scopes with lerna@^6.0.0

➤ YN0000: ┌ Resolution step
➤ YN0060: │ websocket-test@workspace:. provides lerna (p08b9d) with version 6.0.1, which doesn't satisfy what @commitlint/config-lerna-scopes requests
➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code
➤ YN0000: └ Completed

Affected packages

  • cli
  • core
  • prompt
  • config-angular
  • config-lerna-scopes

Possible Solution

Modify peerDependency "lerna": "^5.0.0" to "lerna": "^5.0.0 || ^6.0.0"

Your Environment

Executable Version
commitlint --version @commitlint/cli@17.1.2
git --version git version 2.24.2 (Apple Git-127)
node --version v16.17.1
@commitlint/config-lerna-scopes ^17.0.2
lerna ^6.0.1
yarn -v 3.2.4
@JaneJeon
Copy link
Contributor

+1 on this, it's insanely annoying to have to deal with the version warnings when I can't even override them (and causes lerna's bootstrapping to fail).

@escapedcat
Copy link
Member

Happy for a PR here

escapedcat pushed a commit that referenced this issue Nov 1, 2022
See #3409.

Even with the peerDependencies: optional, npm will *still* kick and scream and end your process if you try to use this with lerna v6.
@escapedcat
Copy link
Member

@JaneJeon
Copy link
Contributor

JaneJeon commented Nov 1, 2022

npm doesn't kick and scream anymore 👍

@escapedcat
Copy link
Member

👏 eventually it will start again someday ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants